From: "Daniel Colascione" <dancol@dancol.org>
To: "Paul Eggert" <eggert@cs.ucla.edu>
Cc: Alan Mackenzie <acm@muc.de>,
Daniel Colascione <dancol@dancol.org>,
emacs-devel@gnu.org
Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.
Date: Wed, 10 Apr 2019 12:02:35 -0700 [thread overview]
Message-ID: <87ebcd1529e31ae7aecfcf8c073d848a.squirrel@dancol.org> (raw)
In-Reply-To: <9809d5ce-c1c4-48e9-6dac-489431b34067@cs.ucla.edu>
> On 4/10/19 11:47 AM, Daniel Colascione wrote:
>> Without CHECK_STRUCTS, we *will* break dumped
>> Emacs in some subtle way sooner or later.
>
> We're gonna break dumped Emacs in subtle ways no matter what. After all,
> pdumper.c was broken in subtle ways when it was first introduced,
> despite CHECK_STRUCTS. That's just life, and it's not the issue here.
> The issue is whether the benefits of the CHECK_STRUCTS mechanism is
> worth the hassle. In my experience it's definitely not worth it.
>
> The more gingerbread we put into the Emacs build procedure, the more
> it's off-putting to other potential developers (and the more work it is
> for us). We already have too much build overhead (starting with
> Autoconf! I hate Autoconf! It should go away!) and we should not neglect
> its costs when looking at the benefits of a new hassle we add to the
> build procedure. So far the benefits of CHECK_STRUCT have been zero in
> the master, and the costs have been slowdown and significant annoyance
> to the developer who's made the most changes to this part of the code.
CHECK_STRUCTS was very useful when pdumper was out of tree and I had to
rebase it regularly. You can disable the thing locally for iterative
development.
next prev parent reply other threads:[~2019-04-10 19:02 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 20:21 CHECK_STRUCTS/dmpstruct.h mechanism is broken Alan Mackenzie
2019-02-28 20:55 ` Eli Zaretskii
2019-02-28 20:59 ` Alan Mackenzie
2019-03-01 7:31 ` Eli Zaretskii
2019-03-01 13:09 ` Alan Mackenzie
2019-03-05 2:17 ` Paul Eggert
2019-04-09 22:47 ` Paul Eggert
2019-04-10 13:12 ` Andy Moreton
2019-04-10 14:59 ` Andy Moreton
2019-04-10 17:36 ` Paul Eggert
2019-04-10 19:26 ` Andy Moreton
2019-04-10 19:43 ` Daniel Colascione
2019-04-10 16:22 ` Alan Mackenzie
2019-04-10 18:05 ` Paul Eggert
2019-04-10 19:45 ` Alan Mackenzie
2019-04-10 20:11 ` Daniel Colascione
2019-04-11 4:11 ` Paul Eggert
2019-04-15 12:36 ` Andy Moreton
2019-04-15 15:32 ` Andy Moreton
2019-04-15 15:53 ` Paul Eggert
2019-04-11 13:13 ` Stefan Monnier
2019-04-11 4:17 ` Paul Eggert
2019-04-10 18:47 ` Daniel Colascione
2019-04-10 18:58 ` Paul Eggert
2019-04-10 19:02 ` Daniel Colascione [this message]
2019-04-10 19:22 ` Eli Zaretskii
2019-04-11 9:35 ` Robert Pluim
2019-04-11 18:31 ` Paul Eggert
2019-04-11 19:15 ` Eli Zaretskii
2019-04-11 22:13 ` Daniel Colascione
2019-04-12 6:44 ` Eli Zaretskii
2019-04-11 22:23 ` Paul Eggert
2019-04-11 22:26 ` Daniel Colascione
2019-04-11 22:38 ` Paul Eggert
2019-04-12 6:39 ` Eli Zaretskii
2019-04-12 19:40 ` Paul Eggert
2019-04-13 9:36 ` Eli Zaretskii
2019-04-14 2:52 ` Paul Eggert
2019-04-12 12:21 ` Andy Moreton
2019-04-12 13:37 ` Alan Mackenzie
2019-04-12 13:55 ` Eli Zaretskii
2019-04-12 13:58 ` Noam Postavsky
2019-04-13 14:06 ` Alan Mackenzie
2019-04-13 14:46 ` About ./configure --cache-file (WAS: CHECK_STRUCTS/dmpstruct.h mechanism is broken.) Noam Postavsky
2019-04-14 2:44 ` Paul Eggert
2019-04-14 3:26 ` Daniel Colascione
2019-04-14 3:49 ` Noam Postavsky
2019-04-14 9:45 ` Alan Mackenzie
2019-04-14 14:08 ` Eli Zaretskii
2019-04-14 14:44 ` Noam Postavsky
2019-04-14 14:53 ` Eli Zaretskii
2019-04-13 8:11 ` CHECK_STRUCTS/dmpstruct.h mechanism is broken Achim Gratz
2019-04-14 2:52 ` Paul Eggert
2019-04-14 3:28 ` Daniel Colascione
2019-04-14 7:22 ` Achim Gratz
2019-04-14 23:29 ` Paul Eggert
2019-04-15 11:31 ` Alan Mackenzie
2019-04-15 14:14 ` Paul Eggert
2019-04-15 18:11 ` Richard Stallman
2019-04-16 18:10 ` Paul Eggert
2019-04-22 2:18 ` Richard Stallman
2019-04-22 4:07 ` Paul Eggert
2019-04-23 1:41 ` Richard Stallman
2019-04-23 3:48 ` Paul Eggert
2019-04-23 6:25 ` Eli Zaretskii
2019-04-23 16:28 ` Paul Eggert
2019-04-23 17:08 ` Eli Zaretskii
2019-04-23 17:19 ` Stefan Monnier
2019-04-24 2:26 ` Richard Stallman
2019-04-15 3:36 ` Richard Stallman
2019-04-15 5:30 ` Paul Eggert
2019-04-11 19:55 ` Achim Gratz
2019-04-11 22:10 ` Daniel Colascione
2019-04-11 22:47 ` Paul Eggert
2019-04-11 22:44 ` Paul Eggert
2019-04-12 17:02 ` Daniele Nicolodi
2019-04-13 8:26 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ebcd1529e31ae7aecfcf8c073d848a.squirrel@dancol.org \
--to=dancol@dancol.org \
--cc=acm@muc.de \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.