From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Magnus Henoch Newsgroups: gmane.emacs.devel Subject: Re: url-http.el: error for redirected proxy connections Date: Fri, 08 Dec 2006 01:46:40 +0100 Message-ID: <87d56vp633.fsf@freemail.hu> References: NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1165538845 26692 80.91.229.10 (8 Dec 2006 00:47:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 8 Dec 2006 00:47:25 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 08 01:47:23 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GsTtV-0000oF-SZ for ged-emacs-devel@m.gmane.org; Fri, 08 Dec 2006 01:47:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GsTtV-0006Z4-IJ for ged-emacs-devel@m.gmane.org; Thu, 07 Dec 2006 19:47:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GsTtJ-0006YG-Cx for emacs-devel@gnu.org; Thu, 07 Dec 2006 19:47:05 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GsTtG-0006VN-Uh for emacs-devel@gnu.org; Thu, 07 Dec 2006 19:47:04 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GsTtG-0006VF-Rv for emacs-devel@gnu.org; Thu, 07 Dec 2006 19:47:02 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GsTtG-0004pI-Or for emacs-devel@gnu.org; Thu, 07 Dec 2006 19:47:02 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GsTt4-0001Fc-O8 for emacs-devel@gnu.org; Fri, 08 Dec 2006 01:46:50 +0100 Original-Received: from etthundrat.olf.sgsnet.se ([193.11.222.85]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 08 Dec 2006 01:46:50 +0100 Original-Received: from mange by etthundrat.olf.sgsnet.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 08 Dec 2006 01:46:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-To: emacs-devel@gnu.org Original-Lines: 30 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: etthundrat.olf.sgsnet.se Mail-Copies-To: never Jabber-Id: legoscia@jabber.cd.chalmers.se User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.90 (berkeley-unix) Cancel-Lock: sha1:sDJGNPl+ocwIPoJj5403EnyrQLk= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63440 Archived-At: Klaus Straubinger writes: > The change > > | * url-http.el (url-http): Make proxy-object buffer-local, to > | handle proxied asynchronous connections correctly. > > introduced a problem when the URL package tries to fetch a redirected > URL trough a proxy connection. The function url-http-create-request has > not the correct value of the variable proxy-object to extract the host > name in this case, resulting in an error message. > > Simply leaving out the line > > (make-local-variable 'proxy-object) > > in function url-http did solve the problem for me. That line was introduced because of my ignorance of the unfruitful interactions of let bindings and buffer-local variables... > The above mentioned correction introduced this line; its purpose had > not been clear to me because proxy-object is only used dynamically > and does not belong to a buffer, as far as I can see. "Not clear" is indeed an accurate description. I have now simplified the code (in particular url-http-create-request), and it seems that proxies and target URLs are now passed along properly. Magnus