From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [simon.marshall@misys.com: Possible mouse-face redisplay glitch] Date: Wed, 17 Jan 2007 14:13:48 -0500 Message-ID: <87d55dxy8j.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1169061253 2686 80.91.229.12 (17 Jan 2007 19:14:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 17 Jan 2007 19:14:13 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 17 20:14:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H7GEW-00064x-Pd for ged-emacs-devel@m.gmane.org; Wed, 17 Jan 2007 20:14:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H7GEX-000537-5I for ged-emacs-devel@m.gmane.org; Wed, 17 Jan 2007 14:14:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H7GEL-00051N-7X for emacs-devel@gnu.org; Wed, 17 Jan 2007 14:13:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H7GEJ-0004yw-DI for emacs-devel@gnu.org; Wed, 17 Jan 2007 14:13:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H7GEJ-0004yl-5Y for emacs-devel@gnu.org; Wed, 17 Jan 2007 14:13:51 -0500 Original-Received: from [18.19.1.138] (helo=cyd.mit.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H7GEG-0002nr-4W; Wed, 17 Jan 2007 14:13:48 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 35D2F4E4F9; Wed, 17 Jan 2007 14:13:48 -0500 (EST) Original-To: rms@gnu.org, storm@cua.dk (Kim F. Storm) In-Reply-To: (Richard Stallman's message of "Tue\, 09 Jan 2007 20\:04\:42 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.92 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65261 Archived-At: Richard Stallman writes: > First generate a calendar in the lower window with: > > M-x calendar RET > > Put mouse over Jan 3 entry such that its mouse-face text property is active > and: > > < > > For me, the position under the mouse (ie, the non-entry above Dec 6 entry) > still appears highlighted in mouse-face. A C-l clears the highlighting. This bug was introduced by the following change: 2006-10-06 Kim F. Storm * xdisp.c (pos_visible_p): Fix value when EOB is visible. *** emacs/src/xdisp.c 2006/10/01 16:44:43 1.1123 --- emacs/src/xdisp.c 2006/10/06 13:30:45 1.1124 *************** *** 1346,1352 **** it2 = it; if (IT_CHARPOS (it) < ZV && FETCH_BYTE (IT_BYTEPOS (it)) != '\n') move_it_by_lines (&it, 1, 0); ! if (charpos < IT_CHARPOS (it)) { visible_p = 1; move_it_to (&it2, charpos, -1, -1, -1, MOVE_TO_POS); --- 1346,1353 ---- it2 = it; if (IT_CHARPOS (it) < ZV && FETCH_BYTE (IT_BYTEPOS (it)) != '\n') move_it_by_lines (&it, 1, 0); ! if (charpos < IT_CHARPOS (it) ! || (it.what == IT_EOB && charpos == IT_CHARPOS (it))) { visible_p = 1; move_it_to (&it2, charpos, -1, -1, -1, MOVE_TO_POS); Kim, do you remember what the rationale for this change was, and can you think of why this is causing the problem?