all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: [simon.marshall@misys.com: Possible mouse-face redisplay glitch]
Date: Wed, 17 Jan 2007 14:13:48 -0500	[thread overview]
Message-ID: <87d55dxy8j.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1H4RtS-0002NV-U1@fencepost.gnu.org> (Richard Stallman's message of "Tue\, 09 Jan 2007 20\:04\:42 -0500")

Richard Stallman <rms@gnu.org> writes:

> First generate a calendar in the lower window with:
>
> M-x calendar RET
>
> Put mouse over Jan 3 entry such that its mouse-face text property is active
> and:
>
> <
>
> For me, the position under the mouse (ie, the non-entry above Dec 6 entry)
> still appears highlighted in mouse-face.  A C-l clears the highlighting.

This bug was introduced by the following change:

2006-10-06  Kim F. Storm  <storm@cua.dk>

	* xdisp.c (pos_visible_p): Fix value when EOB is visible.

*** emacs/src/xdisp.c	2006/10/01 16:44:43	1.1123
--- emacs/src/xdisp.c	2006/10/06 13:30:45	1.1124
***************
*** 1346,1352 ****
        it2 = it;
        if (IT_CHARPOS (it) < ZV && FETCH_BYTE (IT_BYTEPOS (it)) != '\n')
  	move_it_by_lines (&it, 1, 0);
!       if (charpos < IT_CHARPOS (it))
  	{
  	  visible_p = 1;
  	  move_it_to (&it2, charpos, -1, -1, -1, MOVE_TO_POS);
--- 1346,1353 ----
        it2 = it;
        if (IT_CHARPOS (it) < ZV && FETCH_BYTE (IT_BYTEPOS (it)) != '\n')
  	move_it_by_lines (&it, 1, 0);
!       if (charpos < IT_CHARPOS (it)
! 	  || (it.what == IT_EOB && charpos == IT_CHARPOS (it)))
  	{
  	  visible_p = 1;
  	  move_it_to (&it2, charpos, -1, -1, -1, MOVE_TO_POS);

Kim, do you remember what the rationale for this change was, and can
you think of why this is causing the problem?

  reply	other threads:[~2007-01-17 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10  1:04 [simon.marshall@misys.com: Possible mouse-face redisplay glitch] Richard Stallman
2007-01-17 19:13 ` Chong Yidong [this message]
2007-01-18  9:58   ` Kim F. Storm
2007-01-18 16:31     ` Chong Yidong
2007-01-19 15:51       ` Kim F. Storm
  -- strict thread matches above, loose matches on Subject: below --
2007-01-17  2:17 Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d55dxy8j.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.