From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: Fwd: pcomplete bug with special display buffers Date: Tue, 06 Mar 2007 04:05:24 +0100 Organization: disorganized Message-ID: <87d53noyvf.fsf@localhorst.mine.nu> References: <878xec86jk.fsf@localhorst.mine.nu> <874pozlhnq.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173150563 4303 80.91.229.12 (6 Mar 2007 03:09:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Mar 2007 03:09:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 06 04:09:14 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HOQ36-0000Bu-Mv for ged-emacs-devel@m.gmane.org; Tue, 06 Mar 2007 04:09:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOQ36-0005Ck-9t for ged-emacs-devel@m.gmane.org; Mon, 05 Mar 2007 22:09:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HOQ2v-0005Cf-84 for emacs-devel@gnu.org; Mon, 05 Mar 2007 22:09:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HOQ2s-0005AK-Lt for emacs-devel@gnu.org; Mon, 05 Mar 2007 22:08:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOQ2s-0005AH-Fw for emacs-devel@gnu.org; Mon, 05 Mar 2007 22:08:58 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HOQ2r-0003Bt-1a for emacs-devel@gnu.org; Mon, 05 Mar 2007 22:08:57 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HOQ2Z-0004pz-IG for emacs-devel@gnu.org; Tue, 06 Mar 2007 04:08:39 +0100 Original-Received: from e178063185.adsl.alicedsl.de ([85.178.63.185]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Mar 2007 04:08:39 +0100 Original-Received: from david.hansen by e178063185.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Mar 2007 04:08:39 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 55 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: e178063185.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) Cancel-Lock: sha1:WI6CILEvhHHClsa7jdN0DGLruZg= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67395 Archived-At: On Mon, 05 Mar 2007 12:33:13 -0500 Chong Yidong wrote: > David Hansen writes: > >> Hello, >> >> is there anything wrong with this one character patch or did it just >> got lost? >> >> I'm using it now for about two weeks and it seems to work pretty >> well. > > Looks good; I checked it in. Thanks. Thanks. In the meantime I noticed that the (more or less same) bug is spread all over the GNU Emacs sources (well, I might exaggerate a bit). The attached patch is for lisp.el, the same happens at least in comint.el, I haven't investigated the other results that a grep showed me. The bug in lisp and comint completion won't throw an error as in pcomplete.el. To reproduce it you have resize the special frame so that not all possible completions fit within the window. Repeated TAB key strokes won't scroll the buffer. Not sure if your improvements to the pcomplete patch make sense here too (note the `last-command-check'). Maybe 'visible instead of t? When we are at it: what's a good solution to the following problem: as you may have noticed ;-) I made some other changes to comint.el but only want to send the diff that solves the *Completion* buffer problem. How do you deal with this? David *** lisp.el 24 Jan 2007 06:19:42 +0100 1.78 --- lisp.el 06 Mar 2007 03:52:16 +0100 *************** *** 583,589 **** considered." (interactive) ! (let ((window (get-buffer-window "*Completions*"))) (if (and (eq last-command this-command) window (window-live-p window) (window-buffer window) (buffer-name (window-buffer window))) --- 583,589 ---- considered." (interactive) ! (let ((window (get-buffer-window "*Completions*" t))) (if (and (eq last-command this-command) window (window-live-p window) (window-buffer window) (buffer-name (window-buffer window)))