Re: Fwd: pcomplete bug with special display buffers

[David Hansen <david.hansen@gmx.net>]

On Mon, 05 Mar 2007 12:33:13 -0500 Chong Yidong wrote:

> David Hansen <david.hansen@gmx.net> writes:
>
>> Hello,
>>
>> is there anything wrong with this one character patch or did it just
>> got lost?
>>
>> I'm using it now for about two weeks and it seems to work pretty
>> well.
>
> Looks good; I checked it in.  Thanks.

Thanks.  In the meantime I noticed that the (more or less same) bug
is spread all over the GNU Emacs sources (well, I might exaggerate a
bit).  The attached patch is for lisp.el, the same happens at least
in comint.el, I haven't investigated the other results that a grep
showed me.

The bug in lisp and comint completion won't throw an error as in
pcomplete.el.  To reproduce it you have resize the special frame so
that not all possible completions fit within the window. Repeated TAB
key strokes won't scroll the buffer.

Not sure if your improvements to the pcomplete patch make sense here
too (note the `last-command-check').  Maybe 'visible instead of t?

When we are at it:  what's a good solution to the following problem:
as you may have noticed ;-) I made some other changes to comint.el
but only want to send the diff that solves the *Completion* buffer
problem.  How do you deal with this?

David

*** lisp.el	24 Jan 2007 06:19:42 +0100	1.78
--- lisp.el	06 Mar 2007 03:52:16 +0100	
***************
*** 583,589 ****
  considered."
    (interactive)
  
!   (let ((window (get-buffer-window "*Completions*")))
      (if (and (eq last-command this-command)
  	     window (window-live-p window) (window-buffer window)
  	     (buffer-name (window-buffer window)))
--- 583,589 ----
  considered."
    (interactive)
  
!   (let ((window (get-buffer-window "*Completions*" t)))
      (if (and (eq last-command this-command)
  	     window (window-live-p window) (window-buffer window)
  	     (buffer-name (window-buffer window)))