From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: display-completion-list should not strip text properties Date: Thu, 05 Apr 2007 21:59:21 -0400 Message-ID: <87d52ifekm.fsf@stupidchicken.com> References: <878xd8dw3d.fsf@stupidchicken.com> <17941.35328.281122.300772@farnswood.snap.net.nz> <5y7isq2tho.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1175824796 30331 80.91.229.12 (6 Apr 2007 01:59:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2007 01:59:56 +0000 (UTC) Cc: Nick Roberts , rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 06 03:59:34 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HZdjh-0002uM-OS for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2007 03:59:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HZdn8-0001Li-9q for ged-emacs-devel@m.gmane.org; Thu, 05 Apr 2007 22:03:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HZdn4-0001LS-Gv for emacs-devel@gnu.org; Thu, 05 Apr 2007 22:03:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HZdn3-0001LK-72 for emacs-devel@gnu.org; Thu, 05 Apr 2007 22:03:01 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HZdjb-0007lQ-UF; Thu, 05 Apr 2007 21:59:28 -0400 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l361xQtw013233; Thu, 5 Apr 2007 21:59:26 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l361xNpZ029662; Thu, 5 Apr 2007 21:59:23 -0400 (EDT) Original-Received: from localhost (SYDNEYPACIFIC-FIVE-FORTY-FIVE.MIT.EDU [18.95.7.34]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l361xMZP027640; Thu, 5 Apr 2007 21:59:22 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HZdjV-0001Z9-00; Thu, 05 Apr 2007 21:59:21 -0400 In-Reply-To: <5y7isq2tho.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu\, 05 Apr 2007 21\:15\:31 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.97 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: 1 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69105 Archived-At: Glenn Morris writes: > The plan would be to remove all his contributions. > > Where some essential functionality goes, I imagine the person doing > the removing would have to describe what the removed code did in > general terms, then someone else would have to re-implement it > independently. Annoying, but not insurmountable. I went back and checked his contributions more carefully. I now think it's not difficult to revert almost all his changes. There was a big change he made to compile.el, but it was subsequently obseleted by Daniel Pfeiffer's big revamp of compile.el on 2004-03-11, which deleted the variables and functions that Kevin Rodgers had introduced on 1996-11-04. If we revert all his doc/comment fixes, and reimplement two of his changes, we can bring the his remaining contributions to 9 small changes spread over a total of 27 lines. This will introduce a few minor typos into Emacs, but absolutely no loss of functionality. The two changes that we have to reimplement are the following: 1997-03-24 Kevin Rodgers * compile.el (grep-program): New variable. (grep-command): Use it, and test whether it supports the -e option; fix doc string (last command is stored in history variable). (grep-null-device): Declare before grep-program and grep-command. (grep-find-use-xargs, grep-find-command, grep-find-history): New variables. (grep-find): New command. (grep): Only concatenate grep-null-device to COMMAND when it's not nil (to support grep-find). 1996-09-12 Kevin Rodgers * loadhist.el (read-feature): New function. (unload-feature): Read FEATURE interactively with read-feature. I can probably do this in a day. Should I go ahead with the big revert? -------------------------------- These are Kevin Rodger's changes in src/ChangeLog* and lisp/ChangeLog*: 1994-06-17 mailabbrev.el (build-mail-abbrevs): 1 line fix. 1994-07-11 mailabbrev.el (define-mail-abbrev): 2 line fix. 1994-08-26 xfns.c (Fx_color_defined_p): Obsolete. (Fx_color_defined_p has been rewritten in Lisp.) 1995-03-23 print.c (temp_output_buffer_setup): 1 line change. Revertable. 1995-04-20 dired-x.el: 1 line fix. 2 line doc fix, revertable. 1995-05-19 mailalias.el (expand-mail-aliases): 2 line regexp fix. Revertable. 1995-05-19 sendmail.el (mail-mode, mail-text): 6 line doc fix. Revertable. 1995-06-30 mailabbrev.el (mail-resolve-all-aliases-1): 1 line fix. 1995-11-10 files.el (find-file-noselect): 3 line fix. 1995-12-13 ange-ftp.el (ange-ftp-load): 1 line fix. Plus 2 line fix in code that's been rewritten. 1996-09-12 loadhist.el (read-feature): New fun used only in unload-feature. Trivially re-implementable. 1996-10-20 (compilation-skip-to-next-location): New var, defaults to nil 5 line fix to use it. Revertable. 1996-11-04 compile.el (compile-highlight-display-limit): New var, since deleted (compilation-handle-exit): This function has been rewritten. (compile-reinitialize-errors): This function has been deleted. (compilation-forget-errors): This function has been rewritten. 1997-03-24 compile.el (grep-program): New variable. (grep-command): New command. (grep-find): New command. 1997-11-02 emacs-lisp/byte-opt.el (byte-optimize-concat): New function. Revertable. (It's an optional optimization.) 1997-12-22 simple.el (previous-matching-history-element): 5 line fix. 1998-06-03 replace.el (esc-map): 1 line keybinding. 1998-07-07 vc.el (vc-finish-logentry): 1 line fix. 2003-03-06 ffap.el (dired-at-point): 2 line change. Revertable. 2003-03-07 dired-x.el (dired-guess-shell-case-fold-search): New user option. (dired-guess-default): 1 line change to use it. Revertable. 2003-07-25 menu-bar.el (menu-bar-tools-menu): 2 line menu string change. Revertable. 2003-09-01 progmodes/compile.el (previous-error): 5 line change. 2004-11-12 desktop.el (desktop-create-buffer, desktop-save): Four line optimization. Revertable. 2005-08-20 progmodes/compile.el (compilation-disable-input) New defcustom, defaults to nil. (compilation-start): 2 line change to use it. Revertable. 2005-12-10 emacs-lisp/lisp.el (lisp-complete-symbol): 6 line fix. 2006-01-27 textmodes/flyspell.el (flyspell-incorrect, flyspell-duplicate): Two line doc fix. Revertable. 2006-12-22 progmodes/sh-script.el (sh-make-vars-local): 1 line typo in string. Revertable. 2006-12-30 files.el (backup-buffer): 1 line change. Revertable. 2007-03-04 diff-mode.el (diff-mode): 4 line doc fix. Revertable.