From: Chong Yidong <cyd@stupidchicken.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Nick Roberts <nickrob@snap.net.nz>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: display-completion-list should not strip text properties
Date: Thu, 05 Apr 2007 21:59:21 -0400 [thread overview]
Message-ID: <87d52ifekm.fsf@stupidchicken.com> (raw)
In-Reply-To: <5y7isq2tho.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu\, 05 Apr 2007 21\:15\:31 -0400")
Glenn Morris <rgm@gnu.org> writes:
> The plan would be to remove all his contributions.
>
> Where some essential functionality goes, I imagine the person doing
> the removing would have to describe what the removed code did in
> general terms, then someone else would have to re-implement it
> independently. Annoying, but not insurmountable.
I went back and checked his contributions more carefully. I now think
it's not difficult to revert almost all his changes. There was a big
change he made to compile.el, but it was subsequently obseleted by
Daniel Pfeiffer's big revamp of compile.el on 2004-03-11, which
deleted the variables and functions that Kevin Rodgers had introduced
on 1996-11-04.
If we revert all his doc/comment fixes, and reimplement two of his
changes, we can bring the his remaining contributions to 9 small
changes spread over a total of 27 lines. This will introduce a few
minor typos into Emacs, but absolutely no loss of functionality.
The two changes that we have to reimplement are the following:
1997-03-24 Kevin Rodgers <kevinr@ihs.com>
* compile.el (grep-program): New variable.
(grep-command): Use it, and test whether it supports the -e
option; fix doc string (last command is stored in history variable).
(grep-null-device): Declare before grep-program and grep-command.
(grep-find-use-xargs, grep-find-command, grep-find-history):
New variables.
(grep-find): New command.
(grep): Only concatenate grep-null-device to COMMAND when it's
not nil (to support grep-find).
1996-09-12 Kevin Rodgers <kevinr@ihs.com>
* loadhist.el (read-feature): New function.
(unload-feature): Read FEATURE interactively with read-feature.
I can probably do this in a day. Should I go ahead with the big revert?
--------------------------------
These are Kevin Rodger's changes in src/ChangeLog* and
lisp/ChangeLog*:
1994-06-17 mailabbrev.el (build-mail-abbrevs): 1 line fix.
1994-07-11 mailabbrev.el (define-mail-abbrev): 2 line fix.
1994-08-26 xfns.c (Fx_color_defined_p):
Obsolete. (Fx_color_defined_p has been rewritten in Lisp.)
1995-03-23 print.c (temp_output_buffer_setup): 1 line change.
Revertable.
1995-04-20 dired-x.el: 1 line fix.
2 line doc fix, revertable.
1995-05-19 mailalias.el (expand-mail-aliases): 2 line regexp fix.
Revertable.
1995-05-19 sendmail.el (mail-mode, mail-text): 6 line doc fix.
Revertable.
1995-06-30 mailabbrev.el (mail-resolve-all-aliases-1): 1 line fix.
1995-11-10 files.el (find-file-noselect): 3 line fix.
1995-12-13 ange-ftp.el (ange-ftp-load): 1 line fix.
Plus 2 line fix in code that's been rewritten.
1996-09-12 loadhist.el (read-feature): New fun used only in unload-feature.
Trivially re-implementable.
1996-10-20 (compilation-skip-to-next-location): New var, defaults to nil
5 line fix to use it.
Revertable.
1996-11-04 compile.el
(compile-highlight-display-limit): New var, since deleted
(compilation-handle-exit): This function has been rewritten.
(compile-reinitialize-errors): This function has been deleted.
(compilation-forget-errors): This function has been rewritten.
1997-03-24 compile.el (grep-program): New variable.
(grep-command): New command.
(grep-find): New command.
1997-11-02 emacs-lisp/byte-opt.el (byte-optimize-concat): New function.
Revertable. (It's an optional optimization.)
1997-12-22 simple.el (previous-matching-history-element): 5 line fix.
1998-06-03 replace.el (esc-map): 1 line keybinding.
1998-07-07 vc.el (vc-finish-logentry): 1 line fix.
2003-03-06 ffap.el (dired-at-point): 2 line change.
Revertable.
2003-03-07 dired-x.el (dired-guess-shell-case-fold-search): New user option.
(dired-guess-default): 1 line change to use it.
Revertable.
2003-07-25 menu-bar.el (menu-bar-tools-menu): 2 line menu string change.
Revertable.
2003-09-01 progmodes/compile.el (previous-error): 5 line change.
2004-11-12 desktop.el (desktop-create-buffer, desktop-save): Four line
optimization.
Revertable.
2005-08-20 progmodes/compile.el (compilation-disable-input) New
defcustom, defaults to nil.
(compilation-start): 2 line change to use it.
Revertable.
2005-12-10 emacs-lisp/lisp.el (lisp-complete-symbol): 6 line fix.
2006-01-27 textmodes/flyspell.el (flyspell-incorrect, flyspell-duplicate):
Two line doc fix.
Revertable.
2006-12-22 progmodes/sh-script.el (sh-make-vars-local): 1 line typo in string.
Revertable.
2006-12-30 files.el (backup-buffer): 1 line change.
Revertable.
2007-03-04 diff-mode.el (diff-mode): 4 line doc fix.
Revertable.
next prev parent reply other threads:[~2007-04-06 1:59 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-22 17:23 display-completion-list should not strip text properties Drew Adams
2007-01-22 18:56 ` Stefan Monnier
2007-01-23 2:07 ` Richard Stallman
2007-01-23 5:10 ` Drew Adams
2007-01-23 21:32 ` Drew Adams
2007-01-24 8:22 ` Richard Stallman
2007-01-24 23:43 ` Johan Bockgård
2007-01-25 10:53 ` Richard Stallman
2007-01-26 13:17 ` Vinicius Jose Latorre
2007-01-27 0:46 ` Richard Stallman
2007-09-01 19:56 ` Drew Adams
2007-09-02 18:52 ` Juri Linkov
2007-09-03 18:25 ` Richard Stallman
2007-09-03 23:48 ` Juri Linkov
2007-09-04 5:59 ` David Kastrup
2007-09-04 9:52 ` Juri Linkov
2007-09-04 8:49 ` tomas
2007-09-04 9:54 ` Juri Linkov
2007-09-04 10:56 ` Johan Bockgård
2007-09-04 22:58 ` Richard Stallman
2007-09-04 16:45 ` Richard Stallman
2007-09-04 18:51 ` Drew Adams
2007-09-04 22:46 ` Davis Herring
2007-09-05 6:16 ` Richard Stallman
2007-09-05 14:21 ` Drew Adams
2007-09-06 4:59 ` Richard Stallman
2007-09-06 16:35 ` Drew Adams
2007-09-06 20:04 ` Edward O'Connor
2007-09-06 20:16 ` Drew Adams
2007-09-06 23:08 ` Robert J. Chassell
2007-09-06 23:42 ` Davis Herring
2007-09-07 12:30 ` Robert J. Chassell
2007-09-08 7:00 ` Richard Stallman
2007-09-07 19:53 ` Richard Stallman
2007-09-07 22:07 ` Drew Adams
2007-09-06 20:06 ` David Kastrup
2007-09-06 20:22 ` Drew Adams
2007-09-07 6:31 ` Richard Stallman
2007-09-05 6:16 ` Richard Stallman
2007-03-20 22:36 ` Drew Adams
2007-04-02 16:55 ` Drew Adams
2007-04-02 18:51 ` Kim F. Storm
2007-04-03 21:40 ` Richard Stallman
2007-04-03 21:53 ` Juanma Barranquero
2007-04-04 14:03 ` Richard Stallman
2007-04-03 22:03 ` Nick Roberts
2007-04-04 14:03 ` Richard Stallman
2007-04-04 14:59 ` Chong Yidong
2007-04-05 23:11 ` Richard Stallman
2007-04-05 23:20 ` Chong Yidong
2007-04-06 19:47 ` Richard Stallman
2007-04-05 23:45 ` Nick Roberts
2007-04-06 1:15 ` Glenn Morris
2007-04-06 1:59 ` Chong Yidong [this message]
2007-04-06 2:22 ` David Kastrup
2007-04-06 4:18 ` Glenn Morris
2007-04-06 8:41 ` Eli Zaretskii
2007-04-06 14:47 ` Chong Yidong
2007-04-06 16:26 ` Kim F. Storm
2007-04-06 17:34 ` Eli Zaretskii
2007-04-07 12:40 ` Richard Stallman
2007-04-06 17:06 ` Kim F. Storm
2007-04-06 19:23 ` Kevin Rodgers changes Chong Yidong
2007-04-07 7:32 ` martin rudalics
2007-04-07 12:40 ` Richard Stallman
2007-04-07 16:57 ` Chong Yidong
2007-04-07 17:34 ` Eli Zaretskii
2007-04-08 12:28 ` Richard Stallman
2007-04-08 21:07 ` Eli Zaretskii
2007-04-09 14:33 ` Daniel Brockman
2007-04-09 15:42 ` Richard Stallman
2007-04-08 21:30 ` Chong Yidong
2007-04-09 15:42 ` Richard Stallman
2007-04-11 16:38 ` display-completion-list should not strip text properties Markus Triska
2007-04-11 17:13 ` Chong Yidong
2007-04-06 19:47 ` Richard Stallman
2007-04-06 8:42 ` Eli Zaretskii
2007-04-06 19:47 ` Richard Stallman
2007-04-04 17:45 ` Edward O'Connor
2007-04-05 14:36 ` Chong Yidong
2007-04-05 15:02 ` Juanma Barranquero
2007-04-05 23:11 ` Richard Stallman
2007-01-24 7:07 ` Kevin Rodgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d52ifekm.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
--cc=rgm@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.