From: Matt Hodges <M.P.Hodges@rl.ac.uk>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.50; add-change-log-entry-other-window and Perl modes.
Date: Thu, 20 Sep 2007 09:51:47 +0100 [thread overview]
Message-ID: <87d4wd90t8.fsf@escpc40.esc.rl.ac.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
In GNU Emacs 23.0.50.4 (i686-pc-linux-gnu, GTK+ Version 2.10.13)
of 2007-09-14 on escpc40
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure '--with-gtk''
add-change-log-entry-other-window stopped detecting the current
subroutine in perl/cperl-mode due to, I think, this change:
revision 1.189
date: 2007-07-20 21:30:51 +0100; author: monnier; state: Exp; lines: +15 -15; commitid: 9SIF7GuRLekDZxqs;
(add-change-log-entry, add-log-current-defun, change-log-merge):
Use derived-mode-p rather than checking major-mode directly.
The attached patch seems to fix it.
Thanks,
Matt
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: add-log.el patch. --]
[-- Type: text/x-patch, Size: 833 bytes --]
--- add-log.el 10 Sep 2007 08:53:06 +0100 1.195
+++ add-log.el 20 Sep 2007 09:44:54 +0100
@@ -802,6 +802,11 @@
"*Modes that look like TeX to `add-log-current-defun'.")
;;;###autoload
+(defvar add-log-perl-like-modes
+ '(perl-mode cperl-mode)
+ "*Modes that look like Perl to `add-log-current-defun'.")
+
+;;;###autoload
(defun add-log-current-defun ()
"Return name of function definition point is in, or nil.
@@ -1016,7 +1021,7 @@
((derived-mode-p 'texinfo-mode)
(if (re-search-backward "^@node[ \t]+\\([^,\n]+\\)" nil t)
(match-string-no-properties 1)))
- ((derived-mode-p '(perl-mode cperl-mode))
+ ((apply 'derived-mode-p add-log-perl-like-modes)
(if (re-search-backward "^sub[ \t]+\\([^({ \t\n]+\\)" nil t)
(match-string-no-properties 1)))
;; Emacs's autoconf-mode installs its own
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next reply other threads:[~2007-09-20 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 8:51 Matt Hodges [this message]
2007-09-20 14:06 ` 23.0.50; add-change-log-entry-other-window and Perl modes Stefan Monnier
2007-09-21 12:23 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4wd90t8.fsf@escpc40.esc.rl.ac.uk \
--to=m.p.hodges@rl.ac.uk \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.