From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: use faces on the mode-line for compile.el Date: Mon, 25 Feb 2008 01:23:28 +0200 Organization: JURTA Message-ID: <87d4qmne6z.fsf@jurta.org> References: <200802232359.m1NNxFpa025055@sallyv1.ics.uci.edu> <87hcfy45iv.fsf@jurta.org> <200802242053.m1OKrDPR007533@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203895469 8669 80.91.229.12 (24 Feb 2008 23:24:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Feb 2008 23:24:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 25 00:24:54 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JTQDF-0003te-7H for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2008 00:24:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JTQCj-0002Vc-Hn for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2008 18:24:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JTQCf-0002VX-Pd for emacs-devel@gnu.org; Sun, 24 Feb 2008 18:24:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JTQCe-0002VH-Bx for emacs-devel@gnu.org; Sun, 24 Feb 2008 18:24:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JTQCd-0002V6-Uk for emacs-devel@gnu.org; Sun, 24 Feb 2008 18:24:16 -0500 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JTQCd-0003na-GI for emacs-devel@gnu.org; Sun, 24 Feb 2008 18:24:15 -0500 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JTQCb-0006UX-4x; Mon, 25 Feb 2008 01:24:13 +0200 In-Reply-To: <200802242053.m1OKrDPR007533@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 24 Feb 2008 12:53:13 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-amd64-linux-gnu) X-Scanner-Signature: 8abf2c83e696415c40c55866f9369f42 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2309 [Feb 24 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 11 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90308 Archived-At: > > > A simple patch can accomplish the above. It uses > > > font-lock-warning-face which is designed to be highly visible. > > > > What do you think about using a special compilation face > > `compilation-error' that inherits from `font-lock-warning-face'? > > No opinion, feel free to change it if it works... Done. I wonder what is the purpose of the following code in `compilation-handle-exit': (if (and (numberp compilation-window-height) (zerop compilation-window-height)) (message "%s" (cdr status))) Is it now unnecessary since it becomes overwritten by another message later? -- Juri Linkov http://www.jurta.org/emacs/