From: Karl Fogel <kfogel@red-bean.com>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: yank-match.el -- yank matches for a regexp from kill-ring
Date: Mon, 03 Mar 2008 20:16:00 -0500 [thread overview]
Message-ID: <87d4qbthkf.fsf@red-bean.com> (raw)
In-Reply-To: <87ablffho4.fsf@jurta.org> (Juri Linkov's message of "Tue\, 04 Mar 2008 02\:35\:31 +0200")
Juri Linkov <juri@jurta.org> writes:
> Modifying `yank-pop' in simple.el to take into account the initial
> command `yank-match' has also benefits of using the recent and more
> correct code to do this. For instance, your command uses `delete-region'
> to replace the previously-yanked text, but `yank-pop' has more advanced
> code that calls (funcall (or yank-undo-function 'delete-region) ...)
>
> Also your command uses `insert' to insert the previously-yanked text,
> but `yank-pop' uses `insert-for-yank' to strip text properties from the
> inserted text according to `yank-excluded-properties'. I guess your patch
> was written when there was no such functions in Emacs?
Probably -- the code is a bit over ten years old now.
> I think it would be safer to reuse code in `yank-pop' and just find
> places in it that differ from `yank-match' functionality, like
> `current-kill'. Maybe you could just add a new match-string argument
> to `current-kill' that will rotate the yanking point by N matching
> places?
All these are good ideas, yup. I grok your general message here:
*really* incorporate 'yank-match' into the existing yank code, don't
just stitch it in in the quickest way possible :-). I will make sure
to DTRT. (I wish we were in bzr already, it would make this slightly
easier... But only slightly, not a big deal either way.)
Thanks for the help!
-Karl
prev parent reply other threads:[~2008-03-04 1:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 23:38 yank-match.el -- yank matches for a regexp from kill-ring Karl Fogel
2007-07-17 18:44 ` Mathias Dahl
2007-07-17 18:46 ` Karl Fogel
2007-07-17 19:29 ` Drew Adams
2007-07-17 20:40 ` Mathias Dahl
2007-07-28 20:32 ` T. V. Raman
2008-03-02 16:17 ` Karl Fogel
2008-03-02 17:59 ` Juri Linkov
2008-03-02 19:25 ` Stefan Monnier
2008-03-02 20:07 ` Juri Linkov
2008-03-02 23:50 ` Karl Fogel
2008-03-04 0:35 ` Juri Linkov
2008-03-04 1:16 ` Karl Fogel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4qbthkf.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.