From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ralf Angeli Newsgroups: gmane.emacs.devel Subject: Re: bug? scroll-lock-mode and searching Date: Fri, 28 Mar 2008 23:19:09 +0100 Message-ID: <87d4pev6ea.fsf@photon.caeruleus.net> References: <20080328.081607.109435269.wl@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1206742784 10506 80.91.229.12 (28 Mar 2008 22:19:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Mar 2008 22:19:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Werner LEMBERG Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 28 23:20:15 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JfMvm-0008Vr-6T for ged-emacs-devel@m.gmane.org; Fri, 28 Mar 2008 23:20:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JfMvA-0000aO-L0 for ged-emacs-devel@m.gmane.org; Fri, 28 Mar 2008 18:19:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JfMv5-0000Yy-Aw for emacs-devel@gnu.org; Fri, 28 Mar 2008 18:19:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JfMv3-0000XS-0I for emacs-devel@gnu.org; Fri, 28 Mar 2008 18:19:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JfMv2-0000XP-6O for emacs-devel@gnu.org; Fri, 28 Mar 2008 18:19:28 -0400 Original-Received: from moutng.kundenserver.de ([212.227.126.188]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JfMux-00005f-Nh; Fri, 28 Mar 2008 18:19:24 -0400 Original-Received: from photon.caeruleus.net (p54A53FA9.dip0.t-ipconnect.de [84.165.63.169]) by mrelayeu.kundenserver.de (node=mrelayeu0) with ESMTP (Nemesis) id 0MKwh2-1JfMuj2vTe-0008PQ; Fri, 28 Mar 2008 23:19:12 +0100 In-Reply-To: <20080328.081607.109435269.wl@gnu.org> (Werner LEMBERG's message of "Fri, 28 Mar 2008 08:16:07 +0100 (CET)") X-Provags-ID: V01U2FsdGVkX1+XmERLzsAr9NU+1NntB9+DgwwPdvp1KI/2W2Y ILb0lE2+8wSX51OFTorq1b4ad5I4BhfLDOnyTK9QIOsuxN5pVp NB36f+/W/Jym5YSiExA7g== X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:93722 Archived-At: * Werner LEMBERG (2008-03-28) writes: > Searching with C-s while scroll-lock-mode is active doesn't center the > search results. I consider this a bug. In case you decide this is a > `feature' I strongly ask for an option to configure scroll-lock-mode > so that isearch always centers its results. I'd consider it neither a bug nor a feature. Scroll Lock mode is simply not aware of Isearch mode and it probably doesn't need to be because a search is not an explicit scrolling command. For me the current behavior is fine, but if other people think it would be a good idea for Scroll Lock mode to center search results, I would not mind adding an option for it. The only problem is that I could not find an appropriate hook in Isearch mode which provides a means to recenter the view. One could perhaps abuse `isearch-message-function' for that but I don't consider this a good idea. Another bad idea would be to advise `isearch-update' like this: (defadvice isearch-update (after scroll-lock-isearch-update activate) "Recenter view after `isearch-update'." (recenter '(4))) -- Ralf