all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ralf Angeli <angeli@caeruleus.net>
To: Werner LEMBERG <wl@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: bug?  scroll-lock-mode and searching
Date: Fri, 28 Mar 2008 23:19:09 +0100	[thread overview]
Message-ID: <87d4pev6ea.fsf@photon.caeruleus.net> (raw)
In-Reply-To: <20080328.081607.109435269.wl@gnu.org> (Werner LEMBERG's message of "Fri, 28 Mar 2008 08:16:07 +0100 (CET)")

* Werner LEMBERG (2008-03-28) writes:

> Searching with C-s while scroll-lock-mode is active doesn't center the
> search results.  I consider this a bug.  In case you decide this is a
> `feature' I strongly ask for an option to configure scroll-lock-mode
> so that isearch always centers its results.

I'd consider it neither a bug nor a feature.  Scroll Lock mode is simply
not aware of Isearch mode and it probably doesn't need to be because a
search is not an explicit scrolling command.

For me the current behavior is fine, but if other people think it would
be a good idea for Scroll Lock mode to center search results, I would
not mind adding an option for it.

The only problem is that I could not find an appropriate hook in Isearch
mode which provides a means to recenter the view.  One could perhaps
abuse `isearch-message-function' for that but I don't consider this a
good idea.  Another bad idea would be to advise `isearch-update' like
this:

(defadvice isearch-update (after scroll-lock-isearch-update activate)
  "Recenter view after `isearch-update'."
  (recenter '(4)))

-- 
Ralf




  reply	other threads:[~2008-03-28 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28  7:16 bug? scroll-lock-mode and searching Werner LEMBERG
2008-03-28 22:19 ` Ralf Angeli [this message]
2008-03-29  4:06   ` Stefan Monnier
2008-03-30  5:49     ` Richard Stallman
2008-03-30  6:06       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4pev6ea.fsf@photon.caeruleus.net \
    --to=angeli@caeruleus.net \
    --cc=emacs-devel@gnu.org \
    --cc=wl@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.