From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul R Newsgroups: gmane.emacs.devel Subject: Re: Maintenance suggestion on an emacs mode Date: Mon, 21 Apr 2008 19:29:53 +0200 Message-ID: <87d4ojxgj2.fsf@gmail.com> References: <87wsn667kw.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208799141 21501 80.91.229.12 (21 Apr 2008 17:32:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Apr 2008 17:32:21 +0000 (UTC) To: "Emacs Devel" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 21 19:32:56 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jnzru-0005c4-2i for ged-emacs-devel@m.gmane.org; Mon, 21 Apr 2008 19:31:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnzrB-0006sz-Mi for ged-emacs-devel@m.gmane.org; Mon, 21 Apr 2008 13:31:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JnzqL-0006Xo-Ls for emacs-devel@gnu.org; Mon, 21 Apr 2008 13:30:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JnzqC-0006U6-SJ for emacs-devel@gnu.org; Mon, 21 Apr 2008 13:30:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnzqC-0006U2-OI for emacs-devel@gnu.org; Mon, 21 Apr 2008 13:30:08 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.158]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JnzqA-0004lN-QY for emacs-devel@gnu.org; Mon, 21 Apr 2008 13:30:08 -0400 Original-Received: by fg-out-1718.google.com with SMTP id d23so2986147fga.30 for ; Mon, 21 Apr 2008 10:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:to:subject:references:from:date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=ziadLKm7wZbHgtzY/hhVQAMteQfCBv95b28hiBIyhwM=; b=kh/RRId3AVcLFIRVaa398Mb5fnTT4rPgzaBACLufHetc5G/ZjjWcuizqM/fsfW11UAFXmysDqBxTLPntgLkLDM2Bd1vMdwYVzKOpuCAGcYJgyI4iaKE+dGygCWbaXMBHtiO6XwgXM4Sy2WkP/ZDukocmLF8s9C0FA22qXuJX+8k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:subject:references:from:date:in-reply-to:message-id:user-agent:mime-version:content-type; b=Tw4oj4OMG2+iy9bM/qCQr9r72zKSklkXRyi7i7RazwEB4Ghogbnds4RuEt6jOFxdR0Kehb5TriAeWRp68rlv8c4u9mmuxyVR+m5PGHRbyGWvmkqAYWtQaj4/iOH2aHvQ0GPL1J0wfqwzBUFW9gAptiwMhyx5wCSoYsr837pNUKw= Original-Received: by 10.86.95.2 with SMTP id s2mr5302382fgb.61.1208798994835; Mon, 21 Apr 2008 10:29:54 -0700 (PDT) Original-Received: from ubuT42 ( [82.242.132.111]) by mx.google.com with ESMTPS id 12sm3433049fgg.6.2008.04.21.10.29.53 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Apr 2008 10:29:54 -0700 (PDT) In-Reply-To: <87wsn667kw.fsf@gmail.com> (Paul R.'s message of "Wed\, 09 Apr 2008 23\:29\:03 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95661 Archived-At: Some missing patches can be found below. I did my best to make acceptable changes, but I might have missed something, let me know if you find something bad. I received the fsf papers, I'll send them back tomorrow. > ,---- RefTex : > > Those bindings are not activated by default, in this sens they are > much like those of modula2 and html-mode. Should they be changed in > the same way ? This patch change them. Index: lisp/textmodes/reftex-vars.el =================================================================== RCS file: /sources/emacs/emacs/lisp/textmodes/reftex-vars.el,v retrieving revision 1.44 diff -U 8 -r1.44 reftex-vars.el --- lisp/textmodes/reftex-vars.el 10 Apr 2008 14:10:44 -0000 1.44 +++ lisp/textmodes/reftex-vars.el 21 Apr 2008 17:21:49 -0000 @@ -1844,17 +1844,26 @@ ;; Miscellaneous configurations ----------------------------------------- (defgroup reftex-miscellaneous-configurations nil "Collection of further configurations." :group 'reftex) (defcustom reftex-extra-bindings nil "Non-nil means, make additional key bindings on startup. -These extra bindings are located in the users `C-c letter' map." +These extra bindings are located in the +`reftex-extra-bindings-map' map, bound to +`reftex-extra-bindings-prefix'." + :group 'reftex-miscellaneous-configurations + :type 'boolean) + +;; below, default is C-c C-y because it is free in LaTeX mode. +(defcustom reftex-extra-bindings-prefix "\C-c\C-y" + "When `reftex-extra-bindings' is set to non-nil, use extra +bindings with this prefix bound to `reftex-extra-bindings-map'." :group 'reftex-miscellaneous-configurations :type 'boolean) (defcustom reftex-plug-into-AUCTeX nil "*Plug-in flags for AUCTeX interface. This variable is a list of 4 boolean flags. When a flag is non-nil, RefTeX will Index: lisp/textmodes/reftex.el =================================================================== RCS file: /sources/emacs/emacs/lisp/textmodes/reftex.el,v retrieving revision 1.86 diff -U 8 -r1.86 reftex.el --- lisp/textmodes/reftex.el 10 Apr 2008 14:10:45 -0000 1.86 +++ lisp/textmodes/reftex.el 21 Apr 2008 17:21:50 -0000 @@ -2399,26 +2399,33 @@ 'reftex-mouse-view-crossref))) ;; Bind `reftex-view-crossref-from-bibtex' in BibTeX mode map (eval-after-load "bibtex" '(define-key bibtex-mode-map "\C-c&" 'reftex-view-crossref-from-bibtex)) ;; If the user requests so, she can have a few more bindings: +(defvar reftex-extra-bindings-map + (let ((map (make-sparse-keymap))) + (define-key map "t" 'reftex-toc) + (define-key map "l" 'reftex-label) + (define-key map "r" 'reftex-reference) + (define-key map "c" 'reftex-citation) + (define-key map "v" 'reftex-view-crossref) + (define-key map "g" 'reftex-grep-document) + (define-key map "s" 'reftex-search-document) + map) + "Reftex extra bindings map") + (when reftex-extra-bindings - (loop for x in - '(("\C-ct" . reftex-toc) - ("\C-cl" . reftex-label) - ("\C-cr" . reftex-reference) - ("\C-cc" . reftex-citation) - ("\C-cv" . reftex-view-crossref) - ("\C-cg" . reftex-grep-document) - ("\C-cs" . reftex-search-document)) - do (define-key reftex-mode-map (car x) (cdr x)))) + (define-key reftex-mode-map + reftex-extra-bindings-prefix + reftex-extra-bindings-map)) + ;;; ========================================================================= ;;; ;;; Menu ;; Define a menu for the menu bar if Emacs is running under X (defvar reftex-isearch-minor-mode nil) > ,---- Gnus-Diary > | Someone wrote something about it but I can't remember what. Emacs > | really needs its bug-tracking system :) > `---- No fixed. > ,---- Inf-lisp > `---- > Maintainer did not answer, should we fix that ? Not fixed. > ,---- Ada Mode > `---- Fixed by the patch below. Index: lisp/progmodes/ada-mode.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/ada-mode.el,v retrieving revision 1.94 diff -U 8 -r1.94 ada-mode.el --- lisp/progmodes/ada-mode.el 24 Feb 2008 10:08:51 -0000 1.94 +++ lisp/progmodes/ada-mode.el 21 Apr 2008 17:21:48 -0000 @@ -445,16 +445,23 @@ The extensions should include a `.' if needed.") (defvar ada-mode-menu (make-sparse-keymap "Ada") "Menu for Ada mode.") (defvar ada-mode-map (make-sparse-keymap) "Local keymap used for Ada mode.") +(defvar ada-mode-extra-map (make-sparse-keymap) + "Keymap used for non-standard keybindings.") + +;; default is C-c C-q because it's free in ada-mode-map +(defvar ada-mode-extra-prefix "\C-c\C-q" + "Prefix key to access `ada-mode-extra-map' functions.") + (defvar ada-mode-abbrev-table nil "Local abbrev table for Ada mode.") (defvar ada-mode-syntax-table nil "Syntax table to be used for editing Ada source code.") (defvar ada-mode-symbol-syntax-table nil "Syntax table for Ada, where `_' is a word constituent.") @@ -4534,16 +4541,19 @@ ;; ------------------------------------------------------------ ;; -- Define keymap and menus for Ada ;; ------------------------------------------------------------- (defun ada-create-keymap () "Create the keymap associated with the Ada mode." + ;; All non-standard keys go into ada-mode-extra-map + (define-key ada-mode-map ada-mode-extra-prefix ada-mode-extra-map) + ;; Indentation and Formatting (define-key ada-mode-map "\C-j" 'ada-indent-newline-indent-conditional) (define-key ada-mode-map "\C-m" 'ada-indent-newline-indent-conditional) (define-key ada-mode-map "\t" 'ada-tab) (define-key ada-mode-map "\C-c\t" 'ada-justified-indent-current) (define-key ada-mode-map "\C-c\C-l" 'ada-indent-region) (define-key ada-mode-map [(shift tab)] 'ada-untab) (define-key ada-mode-map "\C-c\C-f" 'ada-format-paramlist) @@ -4582,33 +4592,33 @@ ;; The following keys are bound to functions defined in ada-xref.el or ;; ada-prj,el., However, RMS rightly thinks that the code should be shared, ;; and activated only if the right compiler is used (define-key ada-mode-map (if (featurep 'xemacs) '(shift button3) [S-mouse-3]) 'ada-point-and-xref) (define-key ada-mode-map [(control tab)] 'ada-complete-identifier) - (define-key ada-mode-map "\C-co" 'ff-find-other-file) + (define-key ada-mode-extra-map "o" 'ff-find-other-file) (define-key ada-mode-map "\C-c5\C-d" 'ada-goto-declaration-other-frame) (define-key ada-mode-map "\C-c\C-d" 'ada-goto-declaration) (define-key ada-mode-map "\C-c\C-s" 'ada-xref-goto-previous-reference) (define-key ada-mode-map "\C-c\C-c" 'ada-compile-application) - (define-key ada-mode-map "\C-cc" 'ada-change-prj) - (define-key ada-mode-map "\C-cd" 'ada-set-default-project-file) - (define-key ada-mode-map "\C-cg" 'ada-gdb-application) + (define-key ada-mode-extra-map "c" 'ada-change-prj) + (define-key ada-mode-extra-map "d" 'ada-set-default-project-file) + (define-key ada-mode-extra-map "g" 'ada-gdb-application) (define-key ada-mode-map "\C-c\C-m" 'ada-set-main-compile-application) - (define-key ada-mode-map "\C-cr" 'ada-run-application) + (define-key ada-mode-extra-map "r" 'ada-run-application) (define-key ada-mode-map "\C-c\C-o" 'ada-goto-parent) (define-key ada-mode-map "\C-c\C-r" 'ada-find-references) - (define-key ada-mode-map "\C-cl" 'ada-find-local-references) + (define-key ada-mode-extra-map "l" 'ada-find-local-references) (define-key ada-mode-map "\C-c\C-v" 'ada-check-current) - (define-key ada-mode-map "\C-cf" 'ada-find-file) + (define-key ada-mode-extra-map "f" 'ada-find-file) - (define-key ada-mode-map "\C-cu" 'ada-prj-edit) + (define-key ada-mode-extra-map "u" 'ada-prj-edit) ;; The templates, defined in ada-stmt.el (let ((map (make-sparse-keymap))) (define-key map "h" 'ada-header) (define-key map "\C-a" 'ada-array) (define-key map "b" 'ada-exception-block) (define-key map "d" 'ada-declare-block) @@ -4631,17 +4641,17 @@ (define-key map "\C-y" 'ada-type) (define-key map "\C-v" 'ada-private) (define-key map "u" 'ada-use) (define-key map "\C-u" 'ada-with) (define-key map "\C-w" 'ada-when) (define-key map "w" 'ada-while-loop) (define-key map "\C-x" 'ada-exception) (define-key map "x" 'ada-exit) - (define-key ada-mode-map "\C-ct" map)) + (define-key ada-mode-extra-map "t" map)) ) (defun ada-create-menu () "Create the Ada menu as shown in the menu bar." (let ((m '("Ada" ("Help" ["Ada Mode" (info "ada-mode") t] > > ,---- rmail-spam-filter > `---- Not fixed. > ,---- mixal-mode > `---- Fixed by the patch below. Index: lisp/progmodes/mixal-mode.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/mixal-mode.el,v retrieving revision 1.16 diff -U 8 -r1.16 mixal-mode.el --- lisp/progmodes/mixal-mode.el 8 Jan 2008 20:46:20 -0000 1.16 +++ lisp/progmodes/mixal-mode.el 21 Apr 2008 17:21:48 -0000 @@ -74,20 +74,20 @@ ;; 09/11/02: started mixal-mode. ;;; Code: (defvar compile-command) ;;; Key map (defvar mixal-mode-map (let ((map (make-sparse-keymap))) - (define-key map "\C-cc" 'compile) - (define-key map "\C-cr" 'mixal-run) - (define-key map "\C-cd" 'mixal-debug) - (define-key map "\C-ho" 'mixal-describe-operation-code) + (define-key map "\C-c\C-c" 'compile) + (define-key map "\C-c\C-r" 'mixal-run) + (define-key map "\C-c\C-d" 'mixal-debug) + (define-key map "\C-h\C-o" 'mixal-describe-operation-code) map) "Keymap for `mixal-mode'.") ;; (makunbound 'mixal-mode-map) ;;; Syntax table (defvar mixal-mode-syntax-table (let ((st (make-syntax-table))) ;; We need to do a bit more to make fontlocking for comments work. -- Paul