From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: David Reitter <david.reitter@gmail.com>,
Emacs-Devel devel <emacs-devel@gnu.org>,
"Lennart Borgman \(gmail\)" <lennart.borgman@gmail.com>,
Miles Bader <miles@gnu.org>
Subject: Re: visual-line-mode
Date: Fri, 11 Jul 2008 17:10:05 -0400 [thread overview]
Message-ID: <87d4lknn4i.fsf@stupidchicken.com> (raw)
In-Reply-To: <jwvabgp1ohw.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 10 Jul 2008 16:23:07 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> PS: My patch is just a proof of concept. It has a few bugs. One of
> them can be seen when you set truncate-lines, in which case it doesn't
> preserve columns correctly (basically, its temporary-goal-column ends
> up being computed from the beginning of the displayed part of the line,
> so as long as hscroll is not changed, it works OK but as soon as
> hscroll is modified, the result is incorrect).
Does the following patch give good results/make sense?
*** trunk/src/indent.c.~1.209.~ 2008-06-29 09:56:50.000000000 -0400
--- trunk/src/indent.c 2008-07-11 17:08:33.000000000 -0400
***************
*** 2058,2067 ****
--- 2058,2070 ----
int it_start;
int oselective;
int it_overshoot_expected;
+ int first_x;
SET_TEXT_POS (pt, PT, PT_BYTE);
start_display (&it, w, pt);
+ first_x = it.first_visible_x;
+
/* Scan from the start of the line containing PT. If we don't
do this, we start moving with IT->current_x == 0, while PT is
really at some x > 0. The effect is, in continuation lines, that
***************
*** 2119,2128 ****
move_it_by_lines (&it, XINT (lines), 0);
if (!NILP (lcols))
! move_it_in_display_line
! (&it, ZV,
! (int)(cols * FRAME_COLUMN_WIDTH (XFRAME (w->frame)) + 0.5),
! MOVE_TO_X);
SET_PT_BOTH (IT_CHARPOS (it), IT_BYTEPOS (it));
}
--- 2122,2135 ----
move_it_by_lines (&it, XINT (lines), 0);
if (!NILP (lcols))
! {
! move_it_in_display_line (&it, ZV, first_x, MOVE_TO_X);
! it.current_x = 0;
! move_it_in_display_line
! (&it, ZV,
! (int)(cols * FRAME_COLUMN_WIDTH (XFRAME (w->frame)) + 0.5),
! MOVE_TO_X);
! }
SET_PT_BOTH (IT_CHARPOS (it), IT_BYTEPOS (it));
}
next prev parent reply other threads:[~2008-07-11 21:10 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 6:30 visual-line-mode David Reitter
2008-06-29 7:05 ` visual-line-mode Miles Bader
2008-06-29 7:19 ` visual-line-mode Miles Bader
2008-06-29 14:01 ` visual-line-mode Stefan Monnier
2008-06-29 15:29 ` visual-line-mode Chong Yidong
2008-06-30 3:07 ` visual-line-mode Miles Bader
2008-06-30 3:15 ` visual-line-mode Chong Yidong
2008-06-30 5:13 ` visual-line-mode Miles Bader
2008-06-30 5:15 ` visual-line-mode Miles Bader
2008-06-30 10:39 ` visual-line-mode Miles Bader
2008-06-30 11:20 ` visual-line-mode Miles Bader
2008-06-30 14:01 ` visual-line-mode Chong Yidong
2008-06-30 16:10 ` visual-line-mode Chong Yidong
2008-07-01 9:10 ` visual-line-mode David Reitter
2008-07-03 19:20 ` visual-line-mode Chong Yidong
2008-07-03 23:56 ` visual-line-mode David Reitter
2008-07-04 10:23 ` visual-line-mode Chong Yidong
2008-07-04 10:58 ` visual-line-mode Miles Bader
2008-07-04 13:04 ` visual-line-mode Chong Yidong
2008-07-04 15:04 ` visual-line-mode David Reitter
2008-07-04 15:49 ` visual-line-mode Stefan Monnier
2008-07-04 16:21 ` visual-line-mode David Reitter
2008-07-05 18:41 ` visual-line-mode Chong Yidong
2008-07-06 1:29 ` visual-line-mode Miles Bader
2008-07-09 14:28 ` visual-line-mode David Reitter
2008-07-10 3:05 ` visual-line-mode Chong Yidong
2008-07-10 12:39 ` visual-line-mode David Reitter
2008-07-10 13:55 ` visual-line-mode Chong Yidong
2008-08-03 13:47 ` visual-line-mode David Reitter
2008-08-11 13:38 ` word-wrap in echo area (was Re: visual-line-mode) David Reitter
2008-08-11 16:03 ` word-wrap in echo area Chong Yidong
2008-07-10 16:37 ` visual-line-mode Chong Yidong
2008-07-10 17:32 ` visual-line-mode Miles Bader
2008-07-10 17:40 ` visual-line-mode Miles Bader
2008-07-10 20:23 ` visual-line-mode Stefan Monnier
2008-07-10 23:23 ` visual-line-mode Chong Yidong
2008-07-10 23:44 ` visual-line-mode Miles Bader
2008-07-10 23:49 ` visual-line-mode Chong Yidong
2008-07-11 13:10 ` visual-line-mode David Reitter
2008-07-14 3:58 ` visual-line-mode Miles Bader
2008-07-14 3:59 ` visual-line-mode Miles Bader
2008-07-11 1:36 ` visual-line-mode Stefan Monnier
2008-07-11 2:30 ` visual-line-mode Miles Bader
2008-07-11 4:36 ` visual-line-mode Chong Yidong
2008-07-11 14:56 ` visual-line-mode David Reitter
2008-07-11 15:57 ` visual-line-mode Chong Yidong
2008-07-11 18:27 ` visual-line-mode Chong Yidong
2008-07-11 20:36 ` visual-line-mode Miles Bader
2008-07-11 21:18 ` visual-line-mode Stefan Monnier
2008-07-11 21:23 ` visual-line-mode David Kastrup
2008-07-11 21:41 ` visual-line-mode David Reitter
2008-07-12 1:49 ` visual-line-mode Stefan Monnier
2008-07-12 8:09 ` visual-line-mode David Kastrup
2008-07-12 16:35 ` visual-line-mode Richard M Stallman
2008-07-12 17:42 ` visual-line-mode Chong Yidong
2008-07-16 4:21 ` visual-line-mode Chong Yidong
2008-07-16 4:37 ` visual-line-mode Miles Bader
2008-07-11 21:10 ` Chong Yidong [this message]
2008-07-12 1:43 ` visual-line-mode Stefan Monnier
2008-07-10 18:08 ` visual-line-mode David Reitter
2008-07-10 23:18 ` visual-line-mode Miles Bader
2008-07-10 23:35 ` visual-line-mode Chong Yidong
2008-07-10 23:49 ` visual-line-mode Chong Yidong
2008-07-09 14:31 ` visual-line-mode David Reitter
2008-07-04 11:09 ` visual-line-mode David Reitter
2008-07-04 12:39 ` visual-line-mode Paul R
2008-06-30 7:32 ` visual-line-mode David Reitter
2008-06-30 7:43 ` visual-line-mode Miles Bader
2008-06-30 7:58 ` visual-line-mode David Reitter
2008-06-30 8:05 ` visual-line-mode Miles Bader
2008-06-30 8:25 ` visual-line-mode David Reitter
2008-06-30 8:30 ` visual-line-mode Miles Bader
2008-07-10 4:53 ` visual-line-mode Chong Yidong
-- strict thread matches above, loose matches on Subject: below --
2009-10-21 14:35 visual-line-mode Quintana Seguí, Pere
2009-10-21 18:24 visual-line-mode Scott Randby
2009-10-21 21:14 ` visual-line-mode Scot Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4lknn4i.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=lennart.borgman@gmail.com \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.