From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#553: 23.0.60; Unknown button type `quail-keyboard-layout-button' Date: Sun, 13 Jul 2008 01:04:42 +0300 Organization: JURTA Message-ID: <87d4likbd1.fsf@jurta.org> Reply-To: Juri Linkov , 553@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1215901654 31304 80.91.229.12 (12 Jul 2008 22:27:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jul 2008 22:27:34 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 13 00:28:21 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KHnZk-0008Su-F9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jul 2008 00:28:20 +0200 Original-Received: from localhost ([127.0.0.1]:35187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHnYs-0007lZ-6X for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jul 2008 18:27:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KHnYm-0007j5-0t for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2008 18:27:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KHnYk-0007i2-Ld for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2008 18:27:19 -0400 Original-Received: from [199.232.76.173] (port=37376 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHnYk-0007hz-CH for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2008 18:27:18 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33585) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KHnYj-0004ki-Tx for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2008 18:27:18 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6CMRFfZ017743; Sat, 12 Jul 2008 15:27:16 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m6CMF3E3014347; Sat, 12 Jul 2008 15:15:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 12 Jul 2008 22:15:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 553 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.121590034413051 (code B ref -1); Sat, 12 Jul 2008 22:15:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 12 Jul 2008 22:05:44 +0000 Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6CM5ZG9013045 for ; Sat, 12 Jul 2008 15:05:36 -0700 Original-Received: from mx10.gnu.org ([199.232.76.166]:38362) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KHnDE-0002Ak-Vi for emacs-pretest-bug@gnu.org; Sat, 12 Jul 2008 18:05:05 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KHnDf-0002Tr-9E for emacs-pretest-bug@gnu.org; Sat, 12 Jul 2008 18:05:34 -0400 Original-Received: from relay03.kiev.sovam.com ([62.64.120.201]:57026) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KHnDe-0002Tj-Pz for emacs-pretest-bug@gnu.org; Sat, 12 Jul 2008 18:05:31 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1KHnDd-000Ozo-3J for emacs-pretest-bug@gnu.org; Sun, 13 Jul 2008 01:05:29 +0300 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 8fcfa5a562f326ba64a474cd1db6e25e X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 4292 [July 12 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Sat, 12 Jul 2008 18:27:19 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18709 gmane.emacs.pretest.bugs:22725 Archived-At: 1. `emacs -Q' 2. `M-: (require 'help-mode) RET' or run any Help command that loads this mode 3. Activate an input method by C-\ 4. Click `mouse-3' on the input method's indicator on the mode-line It fills the *Help* buffer with the text only until it tries to create a button, and fails with the error "make-text-button: Unknown button type `quail-keyboard-layout-button'". This is because `quail-help-init' fails to define new button types. It currently has the form: (defun quail-help-init () (unless (featurep 'help-mode) (require 'help-mode) (define-button-type 'quail-keyboard-layout-button :supertype 'help-xref 'help-function '(lambda (layout) (help-setup-xref `(quail-keyboard-layout-button ,layout) nil) (quail-show-keyboard-layout layout)) 'help-echo (purecopy "mouse-2, RET: show keyboard layout")) (define-button-type 'quail-keyboard-customize-button :supertype 'help-customize-variable 'help-echo (purecopy "mouse-2, RET: customize keyboard layout")))) So it doesn't define two button types if `help-mode' is already loaded. I guess it was done to define them only once, and not redefine on next invocations. Instead of checking for (featurep 'help-mode) it could check if these buttons were already defined. I can't find a function like `button-defined-p' to do this. But the following check seems to work: (get 'quail-keyboard-layout-button 'button-category-symbol) -- Juri Linkov http://www.jurta.org/emacs/