* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
@ 2008-08-08 20:56 ` Stefan Monnier
2008-08-12 18:51 ` Ralf Angeli
2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
` (3 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2008-08-08 20:56 UTC (permalink / raw)
To: Ralf Angeli; +Cc: 662, Chong Yidong
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
BTW, shouldn't Gnus "just" set scroll-margin (and such things)
buffer-locally in its article buffer, so as to isolate it from
such problems?
Or maybe not buffer-locally but let-bound around a call to redisplay?
Stefan
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 20:56 ` Stefan Monnier
@ 2008-08-12 18:51 ` Ralf Angeli
0 siblings, 0 replies; 13+ messages in thread
From: Ralf Angeli @ 2008-08-12 18:51 UTC (permalink / raw)
To: Stefan Monnier, ding; +Cc: 662, Chong Yidong
* Stefan Monnier (2008-08-08) writes:
> BTW, shouldn't Gnus "just" set scroll-margin (and such things)
> buffer-locally in its article buffer, so as to isolate it from
> such problems?
> Or maybe not buffer-locally but let-bound around a call to redisplay?
I guess this is something to decide for the Gnus developers, so I am
forwarding the message to the Gnus list.
Note that this discussion is centered around the recentering bug I
reported earlier on the Gnus list, so this is not related to a new bug.
--
Ralf
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
2008-08-08 20:56 ` Stefan Monnier
@ 2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
` (2 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: ＯＦＦＩＣＥ ZERO @ 2008-08-09 1:00 UTC (permalink / raw)
To: Ralf Angeli, 662
配信不要
----- Original Message -----
From: "Ralf Angeli" <angeli@caeruleus.net>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: <662@emacsbugs.donarmstrong.com>
Sent: Saturday, August 09, 2008 3:32 AM
Subject: bug#662: 23.0.60; Constant recentering with scroll-margin set
>* Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
>
> --
> Ralf
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
2008-08-08 20:56 ` Stefan Monnier
2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
@ 2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
2008-08-09 1:30 ` Chong Yidong
2008-08-09 14:13 ` bug#662: " ＯＦＦＩＣＥ ZERO
4 siblings, 0 replies; 13+ messages in thread
From: ＯＦＦＩＣＥ ZERO @ 2008-08-09 1:07 UTC (permalink / raw)
To: Ralf Angeli, 662
配信不要
----- Original Message -----
From: "Ralf Angeli" <angeli@caeruleus.net>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: <662@emacsbugs.donarmstrong.com>
Sent: Saturday, August 09, 2008 3:32 AM
Subject: bug#662: 23.0.60; Constant recentering with scroll-margin set
>* Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
>
> --
> Ralf
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
` (2 preceding siblings ...)
2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
@ 2008-08-09 1:30 ` Chong Yidong
2008-08-09 1:40 ` Lennart Borgman (gmail)
2008-08-12 19:15 ` Stefan Monnier
2008-08-09 14:13 ` bug#662: " ＯＦＦＩＣＥ ZERO
4 siblings, 2 replies; 13+ messages in thread
From: Chong Yidong @ 2008-08-09 1:30 UTC (permalink / raw)
To: emacs-devel
Ralf Angeli <angeli@caeruleus.net> writes:
> * Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then
> I can report this to the Gnus maintainers.
What do people think? When there is a scroll-margin, should
move-to-window-line automagically move to the scroll-margin instead of
recentering?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: 23.0.60; Constant recentering with scroll-margin set
2008-08-09 1:30 ` Chong Yidong
@ 2008-08-09 1:40 ` Lennart Borgman (gmail)
2008-08-12 19:15 ` Stefan Monnier
1 sibling, 0 replies; 13+ messages in thread
From: Lennart Borgman (gmail) @ 2008-08-09 1:40 UTC (permalink / raw)
To: Chong Yidong; +Cc: emacs-devel
Chong Yidong wrote:
> Ralf Angeli <angeli@caeruleus.net> writes:
>
>> * Ralf Angeli (2008-08-07) writes:
>>
>>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>>> remember that there was a similar issue back in 2005 where some changes
>>> hat to be made in `gnus-article-next-page' and related functions in
>>> order to deal with some changes in the handling of `scroll-margin'.
>> Okay, the problem is the statement
>> (move-to-window-line -1)
>> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
>> 0 it will lead to a recentering. This is usually countered by
>> `gnus-article-next-page-1', but not at the end of an article where
>> `gnus-article-next-page-1' will not be called.
>>
>> The problem can be circumvented by changing the above statement to
>> (move-to-window-line (- -1 scroll-margin))
>>
>> Let me know if the recentering behavior will stay like it is now, then
>> I can report this to the Gnus maintainers.
>
> What do people think? When there is a scroll-margin, should
> move-to-window-line automagically move to the scroll-margin instead of
> recentering?
Yes. Automatic recentering is very disturbing IMO.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.60; Constant recentering with scroll-margin set
2008-08-09 1:30 ` Chong Yidong
2008-08-09 1:40 ` Lennart Borgman (gmail)
@ 2008-08-12 19:15 ` Stefan Monnier
2008-08-13 2:33 ` Miles Bader
1 sibling, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2008-08-12 19:15 UTC (permalink / raw)
To: Chong Yidong; +Cc: emacs-devel
> What do people think? When there is a scroll-margin, should
> move-to-window-line automagically move to the scroll-margin instead of
> recentering?
I never used it, neither interactively nor programmatically, so I don't
have a strong opinion on that. Reading the docstring I get the
impression that the intention is to place the cursor at a particular
location within the window, rather than to place point at a particular
location within the buffer. So that leads me to think that it should
never cause recentering. Maybe if the operation cannot be performed,
the function should return the number of lines "left".
Stefan
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: 23.0.60; Constant recentering with scroll-margin set
2008-08-12 19:15 ` Stefan Monnier
@ 2008-08-13 2:33 ` Miles Bader
0 siblings, 0 replies; 13+ messages in thread
From: Miles Bader @ 2008-08-13 2:33 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Chong Yidong, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> What do people think? When there is a scroll-margin, should
>> move-to-window-line automagically move to the scroll-margin instead of
>> recentering?
>
> I never used it, neither interactively nor programmatically, so I don't
> have a strong opinion on that. Reading the docstring I get the
> impression that the intention is to place the cursor at a particular
> location within the window, rather than to place point at a particular
> location within the buffer. So that leads me to think that it should
> never cause recentering. Maybe if the operation cannot be performed,
> the function should return the number of lines "left".
I use this function constantly -- I have simple wrappers bound to M-,
M-/ and M-. to move to the top, middle, and bottom of the window.
I almost never use a non-zero scroll-margin, so I don't have that much
experience with this problem, but I agree that it feels kind of weird if
move-to-window-line causes scrolling.
I kinda wish it would simply "disobey" the scroll-margin and locate the
cursor there without scrolling, but that probably isn't easy to
implement.
The suggested behavior of "stopping short", by having it move to line
(min (max N scroll-margin) (- window-height scroll-margin)) seems
reasonable interactively.
It might surprise some programmatic users, but on the other hand,
scrolling will probably surprise them too, so I guess there's really not
much you can do in that case; such code probably simply isn't prepared
to deal with a non-zero scroll-margin...
-Miles
--
`To alcohol! The cause of, and solution to,
all of life's problems' --Homer J. Simpson
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
` (3 preceding siblings ...)
2008-08-09 1:30 ` Chong Yidong
@ 2008-08-09 14:13 ` ＯＦＦＩＣＥ ZERO
4 siblings, 0 replies; 13+ messages in thread
From: ＯＦＦＩＣＥ ZERO @ 2008-08-09 14:13 UTC (permalink / raw)
To: Ralf Angeli, 662
Do'nt send me mail !!!
no tkank you!!
----- Original Message -----
From: "Ralf Angeli" <angeli@caeruleus.net>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: <662@emacsbugs.donarmstrong.com>
Sent: Saturday, August 09, 2008 3:32 AM
Subject: bug#662: 23.0.60; Constant recentering with scroll-margin set
>* Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
>
> --
> Ralf
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread