* Newsticker is jealous
@ 2008-10-31 14:42 Paul R
0 siblings, 0 replies; 4+ messages in thread
From: Paul R @ 2008-10-31 14:42 UTC (permalink / raw)
To: emacs-devel
Hello,
I've been using newsticker 1.99 in treeview mode since I use emacs23.
Today I noticed a bug. It may be related to the retrieval method that
I changed recently, now I use wget external tool.
To reproduce, set the retrieval method to gnus, run newsticker in
treeview, then pop up scratch buffer and hit C-x 1. Now you can't see
any pane of newsticker, and he feels bad about that. Whenever he will
retreive some feeds, it will raise the error below :
-----------------------------------------
Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 6>)
set-window-buffer(#<window 6> #<buffer *Newsticker List*>)
(save-excursion (set-window-buffer (newsticker--treeview-list-window) (newsticker--treeview-list-buffer)) (set-buffer (newsticker--treeview-list-buffer)) (if clear-buffer (let ... ...)) (newsticker-treeview-list-mode) (newsticker--treeview-list-update-faces) (goto-char (point-min)))
newsticker--treeview-list-update(t)
newsticker-treeview-update()
funcall(newsticker-treeview-update)
(progn (funcall newsticker--sentinel-callback))
(if newsticker--sentinel-callback (progn (funcall newsticker--sentinel-callback)))
(when newsticker--sentinel-callback (funcall newsticker--sentinel-callback))
newsticker--sentinel-work("finished\n" t "Planet GNOME" ("wget" "-q" "-O" "-" "http://planet.gnome.org/rss20.xml") #<killed buffer>)
(let ((p-status ...) (exit-status ...) (name ...) (command ...) (buffer ...)) (newsticker--sentinel-work event (and ... ...) name command buffer))
newsticker--sentinel(#<process Planet GNOME> "finished\n")
-----------------------------------------
Below are some infos on the build and the modes
In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
of 2008-10-30 on ubuT42
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using `configure '--prefix=/home/paul/Software/local' '--program-suffix=.emacs-23.0.60' '--with-x-toolkit=gtk''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: fr_FR.UTF-8
value of $LC_CTYPE: en_US.UTF-8
value of $LC_MESSAGES: en_US.UTF-8
value of $LC_MONETARY: fr_FR.UTF-8
value of $LC_NUMERIC: fr_FR.UTF-8
value of $LC_TIME: fr_FR.UTF-8
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
Major mode: Debugger
Minor modes in effect:
shell-dirtrack-mode: t
csv-field-index-mode: t
display-time-mode: t
show-paren-mode: t
icomplete-mode: t
iswitchb-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
temp-buffer-resize-mode: t
column-number-mode: t
line-number-mode: t
transient-mark-mode: t
(sorry for the duplicate, I messed with my buffers)
--
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* emacsclient on WXP does not work (as it used to)
@ 2008-10-31 10:35 dhruva
2008-10-31 11:02 ` Juanma Barranquero
0 siblings, 1 reply; 4+ messages in thread
From: dhruva @ 2008-10-31 10:35 UTC (permalink / raw)
To: Emacs Devel
Hi,
With recent (day old) changes to emacsclient and server.el, I am not
able to open a file in a running session of emacs.
When I run 'emacsclient some_file' I get the following error even
though I have a session of emacs running (in window mode)
emacsclient: connect: No connection could be made because the target
machine actively refused it.
emacsclient: No socket or alternate editor. Please use:
--server-file (or environment variable EMACS_SERVER_FILE)
--alternate-editor (or environment variable ALTERNATE_EDITOR)
The output of command 'list-processes' in emacs:
Proc Status Buffer Command
---- ------ ------ -------
server listen (none) (network stream server on 1118)
-dhruva
--
Contents reflect my personal views only!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacsclient on WXP does not work (as it used to)
2008-10-31 10:35 emacsclient on WXP does not work (as it used to) dhruva
@ 2008-10-31 11:02 ` Juanma Barranquero
2008-10-31 11:15 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2008-10-31 11:02 UTC (permalink / raw)
To: dhruva; +Cc: Emacs Devel
On Fri, Oct 31, 2008 at 11:35, dhruva <dhruvakm@gmail.com> wrote:
> When I run 'emacsclient some_file' I get the following error even
> though I have a session of emacs running (in window mode)
>
> emacsclient: connect: No connection could be made because the target
> machine actively refused it.
Yes, this change:
http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lib-src/emacsclient.c?r1=1.135&r2=1.136&pathrev=MAIN
is wrong, because on Windows, once inside the if(), tty_name is always
going to be NULL.
I wonder why the whole if isn't just #ifdef'd out. Are there
legitimate uses of tty == 1 on Windows?
The attached patch fixes the problem, but it's ugly as hell.
Juanma
Index: lib-src/emacsclient.c
===================================================================
RCS file: /sources/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.136
diff -u -2 -r1.136 emacsclient.c
--- lib-src/emacsclient.c 30 Oct 2008 15:54:38 -0000 1.136
+++ lib-src/emacsclient.c 31 Oct 2008 11:00:45 -0000
@@ -1441,5 +1441,9 @@
In daemon mode, Emacs may need to occupy this tty if no other
frame is available. */
- if (tty || current_frame)
+ if (tty
+#ifndef WINDOWSNT
+ || current_frame
+#endif
+ )
{
char *type = egetenv ("TERM");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacsclient on WXP does not work (as it used to)
2008-10-31 11:02 ` Juanma Barranquero
@ 2008-10-31 11:15 ` Eli Zaretskii
2008-10-31 12:27 ` Juanma Barranquero
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2008-10-31 11:15 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: emacs-devel
> Date: Fri, 31 Oct 2008 12:02:12 +0100
> From: "Juanma Barranquero" <lekktu@gmail.com>
> Cc: Emacs Devel <emacs-devel@gnu.org>
>
> Yes, this change:
>
> http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lib-src/emacsclient.c?r1=1.135&r2=1.136&pathrev=MAIN
>
> is wrong, because on Windows, once inside the if(), tty_name is always
> going to be NULL.
Can you please explain why is this a problem on Windows? I understand
that the addition of current_frame to the `if' clause causes it to be
entered on Windows, whereas it wasn't before, but how does that, and
the fact that tty_name is NULL, cause emacsclient failure reported by
dhruva?
> I wonder why the whole if isn't just #ifdef'd out. Are there
> legitimate uses of tty == 1 on Windows?
>
> The attached patch fixes the problem, but it's ugly as hell.
Agreed (to the ``ugly'' part). I'd like to try to find a less ugly
fix.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacsclient on WXP does not work (as it used to)
2008-10-31 11:15 ` Eli Zaretskii
@ 2008-10-31 12:27 ` Juanma Barranquero
2008-10-31 14:13 ` Chong Yidong
0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2008-10-31 12:27 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On Fri, Oct 31, 2008 at 12:15, Eli Zaretskii <eliz@gnu.org> wrote:
> Can you please explain why is this a problem on Windows? I understand
> that the addition of current_frame to the `if' clause causes it to be
> entered on Windows, whereas it wasn't before, but how does that, and
> the fact that tty_name is NULL, cause emacsclient failure reported by
> dhruva?
I don't know why dhruva got the "connect" error message. My guess is
that they are two different problems:
1.- emacsclient opened the socket (so no INVALID_SOCKET), but couldn't connect
2.- emacsclient couldn't get the terminal name, and it didn't have
alternate-editor
though I don't know how or why 2) would happen, unless there were two
different emacsclients involved, called through alternate-editor (and
even so, it doesn't make much sense).
But anyway, my point was just that the very next code after the if() is
char *type = egetenv ("TERM");
char *tty_name = NULL;
#ifndef WINDOWSNT
tty_name = ttyname (fileno (stdout));
#endif
if (! tty_name)
{
message (TRUE, "%s: could not get terminal name\n", progname);
fail ();
}
so entering the if() is *always* going to fail(). I'm unable to see
how that be useful on Windows.
> Agreed (to the ``ugly'' part).
Glad we agree on this :)
Have you any comment about the other part? ("Are there legitimate uses
of tty == 1 on Windows?")
> I'd like to try to find a less ugly fix.
It's Chong's patch, perhaps he can shed a bit of light.
Juanma
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacsclient on WXP does not work (as it used to)
2008-10-31 12:27 ` Juanma Barranquero
@ 2008-10-31 14:13 ` Chong Yidong
2008-10-31 14:31 ` Newsticker is jealous Paul R
0 siblings, 1 reply; 4+ messages in thread
From: Chong Yidong @ 2008-10-31 14:13 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Eli Zaretskii, emacs-devel
"Juanma Barranquero" <lekktu@gmail.com> writes:
>> I'd like to try to find a less ugly fix.
>
> It's Chong's patch, perhaps he can shed a bit of light.
This was for bug#1267.
The goal was to pass the tty to the Emacs server even if we're supposed
to use the current frame, because in daemon mode, if the "current frame"
is the fake daemon frame, we wan to be able to fall back on using that
tty.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Newsticker is jealous
2008-10-31 14:13 ` Chong Yidong
@ 2008-10-31 14:31 ` Paul R
2008-10-31 14:43 ` Paul R
0 siblings, 1 reply; 4+ messages in thread
From: Paul R @ 2008-10-31 14:31 UTC (permalink / raw)
To: emacs-devel; +Cc: ulf.jasper
Hello,
I've been using newsticker 1.99 in treeview mode since I use emacs23.
Today I noticed a bug. It may be related to the retrieval method that
I changed recently, now I use wget external tool.
To reproduce, set the retrieval method to gnus, run newsticker in
treeview, then pop up scratch buffer and hit C-x 1. Now you can't see
any pane of newsticker, and he feels bad about that. Whenever he will
retreive some feeds, it will raise the error below :
-----------------------------------------
Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 6>)
set-window-buffer(#<window 6> #<buffer *Newsticker List*>)
(save-excursion (set-window-buffer (newsticker--treeview-list-window) (newsticker--treeview-list-buffer)) (set-buffer (newsticker--treeview-list-buffer)) (if clear-buffer (let ... ...)) (newsticker-treeview-list-mode) (newsticker--treeview-list-update-faces) (goto-char (point-min)))
newsticker--treeview-list-update(t)
newsticker-treeview-update()
funcall(newsticker-treeview-update)
(progn (funcall newsticker--sentinel-callback))
(if newsticker--sentinel-callback (progn (funcall newsticker--sentinel-callback)))
(when newsticker--sentinel-callback (funcall newsticker--sentinel-callback))
newsticker--sentinel-work("finished\n" t "Planet GNOME" ("wget" "-q" "-O" "-" "http://planet.gnome.org/rss20.xml") #<killed buffer>)
(let ((p-status ...) (exit-status ...) (name ...) (command ...) (buffer ...)) (newsticker--sentinel-work event (and ... ...) name command buffer))
newsticker--sentinel(#<process Planet GNOME> "finished\n")
-----------------------------------------
Below are some infos on the build and the modes
In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
of 2008-10-30 on ubuT42
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using `configure '--prefix=/home/paul/Software/local' '--program-suffix=.emacs-23.0.60' '--with-x-toolkit=gtk''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: fr_FR.UTF-8
value of $LC_CTYPE: en_US.UTF-8
value of $LC_MESSAGES: en_US.UTF-8
value of $LC_MONETARY: fr_FR.UTF-8
value of $LC_NUMERIC: fr_FR.UTF-8
value of $LC_TIME: fr_FR.UTF-8
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
Major mode: Debugger
Minor modes in effect:
shell-dirtrack-mode: t
csv-field-index-mode: t
display-time-mode: t
show-paren-mode: t
icomplete-mode: t
iswitchb-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
temp-buffer-resize-mode: t
column-number-mode: t
line-number-mode: t
transient-mark-mode: t
--
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Newsticker is jealous
2008-10-31 14:31 ` Newsticker is jealous Paul R
@ 2008-10-31 14:43 ` Paul R
2008-10-31 17:21 ` Ulf Jasper
0 siblings, 1 reply; 4+ messages in thread
From: Paul R @ 2008-10-31 14:43 UTC (permalink / raw)
To: emacs-devel; +Cc: ulf.jasper
Paul> Hello, I've been using newsticker 1.99 in treeview mode since
Paul> I use emacs23. Today I noticed a bug. It may be related to the
Paul> retrieval method that I changed recently, now I use wget external
Paul> tool.
please forget this post with wrong references, I messed up. I just sent
a duplicate in its own thread.
--
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Newsticker is jealous
2008-10-31 14:43 ` Paul R
@ 2008-10-31 17:21 ` Ulf Jasper
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Jasper @ 2008-10-31 17:21 UTC (permalink / raw)
To: Paul R; +Cc: emacs-devel
Paul R <paul.r.ml@gmail.com> writes:
> Paul> Hello, I've been using newsticker 1.99 in treeview mode since
> Paul> I use emacs23. Today I noticed a bug. It may be related to the
> Paul> retrieval method that I changed recently, now I use wget external
> Paul> tool.
Newsticker is not jealous. It's stupid. It gets confused when the window
layout changes. (This does not depend on the retrieval method.)
I'll fix that.
ulf
--
Klicken Sie HIER und Sie erhalten vier Dosen umsonst
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-31 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-31 14:42 Newsticker is jealous Paul R
-- strict thread matches above, loose matches on Subject: below --
2008-10-31 10:35 emacsclient on WXP does not work (as it used to) dhruva
2008-10-31 11:02 ` Juanma Barranquero
2008-10-31 11:15 ` Eli Zaretskii
2008-10-31 12:27 ` Juanma Barranquero
2008-10-31 14:13 ` Chong Yidong
2008-10-31 14:31 ` Newsticker is jealous Paul R
2008-10-31 14:43 ` Paul R
2008-10-31 17:21 ` Ulf Jasper
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.