From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Chong Yidong <cyd@stupidchicken.com>
Newsgroups: gmane.emacs.devel
Subject: Re: leak in make-network-process
Date: Mon, 29 Dec 2008 21:14:22 -0500
Message-ID: <87d4fa8l4x.fsf@cyd.mit.edu>
References: <200812221802.mBMI28aU001131@mothra.ics.uci.edu>
	<200812291910.mBTJAEUT027466@mothra.ics.uci.edu>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1230603279 5653 80.91.229.12 (30 Dec 2008 02:14:39 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 30 Dec 2008 02:14:39 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Dan Nicolaescu <dann@ics.uci.edu>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 30 03:15:45 2008
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1LHU91-0006i8-Dh
	for ged-emacs-devel@m.gmane.org; Tue, 30 Dec 2008 03:15:43 +0100
Original-Received: from localhost ([127.0.0.1]:56810 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1LHU7n-0002I0-EY
	for ged-emacs-devel@m.gmane.org; Mon, 29 Dec 2008 21:14:27 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LHU7j-0002Hl-6w
	for emacs-devel@gnu.org; Mon, 29 Dec 2008 21:14:23 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LHU7i-0002HZ-Bk
	for emacs-devel@gnu.org; Mon, 29 Dec 2008 21:14:22 -0500
Original-Received: from [199.232.76.173] (port=39238 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LHU7i-0002HW-64
	for emacs-devel@gnu.org; Mon, 29 Dec 2008 21:14:22 -0500
Original-Received: from cyd.mit.edu ([18.115.2.24]:39277)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <cyd@stupidchicken.com>) id 1LHU7i-0007y2-2O
	for emacs-devel@gnu.org; Mon, 29 Dec 2008 21:14:22 -0500
Original-Received: by cyd.mit.edu (Postfix, from userid 1000)
	id 1B5DB57E206; Mon, 29 Dec 2008 21:14:22 -0500 (EST)
In-Reply-To: <200812291910.mBTJAEUT027466@mothra.ics.uci.edu> (Dan
	Nicolaescu's message of "Mon, 29 Dec 2008 11:10:14 -0800 (PST)")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not
	recognized.
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:107405
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/107405>

Dan Nicolaescu <dann@ics.uci.edu> writes:

> Actually only this is needed:
>
>   {
>     struct Lisp_Process *p = XPROCESS (proc);
>     /* Set all Lisp_Object members of struct Lisp_Process to nil.  */
>     p->childp = Qnil;
>     p->status = Qnil;
>   }
>
> Why can't GC get these fields?  Should something like this be checked
> in?

Maybe something else in Lisp is still referring to that dead process
object.