From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: bug#1405: detached GTK+ tool bar Date: Sat, 17 Jan 2009 21:24:50 +0100 Message-ID: <87d4el4r59.fsf@escher.local.home> References: <87hc5zcug7.fsf@cyd.mit.edu> <492937F5.1040301__9972.48901189796$1227438707$gmane$org@swipnet.se> <87ej12m1ar.fsf@escher.local.home> <494A9B6E.6060307__43219.0094412819$1229627215$gmane$org@swipnet.se> <87tz91ky8s.fsf__3258.61482783711$1229634381$gmane$org@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1232223918 29880 80.91.229.12 (17 Jan 2009 20:25:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Jan 2009 20:25:18 +0000 (UTC) Cc: Chong Yidong , Jan =?utf-8?Q?Dj=C3=A4rv?= , emacs-devel@gnu.org To: 1405@emacsbugs.donarmstrong.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 17 21:26:29 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LOHkQ-0002yC-NR for ged-emacs-devel@m.gmane.org; Sat, 17 Jan 2009 21:26:26 +0100 Original-Received: from localhost ([127.0.0.1]:49339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOHj9-0001qa-Sx for ged-emacs-devel@m.gmane.org; Sat, 17 Jan 2009 15:25:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOHj4-0001po-Ms for emacs-devel@gnu.org; Sat, 17 Jan 2009 15:25:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOHj2-0001ng-Lk for emacs-devel@gnu.org; Sat, 17 Jan 2009 15:25:02 -0500 Original-Received: from [199.232.76.173] (port=38729 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOHj2-0001nc-IY for emacs-devel@gnu.org; Sat, 17 Jan 2009 15:25:00 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]:44071) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LOHj2-0000aK-4F for emacs-devel@gnu.org; Sat, 17 Jan 2009 15:25:00 -0500 Original-Received: (qmail invoked by alias); 17 Jan 2009 20:24:56 -0000 Original-Received: from i59F56280.versanet.de (EHLO escher.local.home) [89.245.98.128] by mail.gmx.net (mp058) with SMTP; 17 Jan 2009 21:24:56 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/6PnZkVwn6CnI0yZtzo39uJKHPeDiLmVaoQLsgN8 D28Xh5TxDLYPxb Original-Received: by escher.local.home (Postfix, from userid 1000) id AAEE01D0FF2; Sat, 17 Jan 2009 21:24:50 +0100 (CET) In-Reply-To: <87tz91ky8s.fsf__3258.61482783711$1229634381$gmane$org@escher.local.home> (Stephen Berman's message of "Thu, 18 Dec 2008 21:46:27 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107940 Archived-At: On Thu, 18 Dec 2008 21:46:27 +0100 Stephen Berman = wrote: > On Thu, 18 Dec 2008 19:50:22 +0100 Jan Dj=C3=A4rv wr= ote: > >> Stephen Berman skrev: >>> On Sun, 23 Nov 2008 12:01:09 +0100 Jan Dj=C3=A4rv = wrote: >>>> >>>> I'd rather see if the focus can be kept to the frame. We can perhaps = put some >>>> hints to the window manager. I'll look in to it. Can the OP please t= ell us >>>> what window manager he is using and what kind of focus model he has (c= lick to >>>> focus, focus follows mouse)? >>>=20 >>> I'm using KDE/kwin and click to focus. But I also see the same behavior >>> (i.e. focus not returning to the window/frame the tool bar was detached >>> from) with a focus follows mouse policy. >>>=20 >> >> I've made a change, can you test it? >> >> Thanks, >> >> Jan D. > > I just did, and confirm that focus now switches back to the frame after > clicking a button on the detached tool bar. Thanks!=20=20 I just learned about the variable x-gtk-whole-detached-tool-bar; when this is non-nil and the tool bar is detached, focus fails to switch back to the frame after clicking a button on the detached tool bar. So your fix does not work with x-gtk-whole-detached-tool-bar non-nil. In GNU Emacs 23.0.60.29 (i686-pc-linux-gnu, GTK+ Version 2.14.4) of 2009-01-11 on escher=20 Steve Berman