From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#1990: 23.0.60; Emacs trying too hard to find fonts that don't exist Date: Sat, 24 Jan 2009 14:47:16 -0500 Message-ID: <87d4ec1o6z.fsf@cyd.mit.edu> References: <87sknaaa0m.fsf@cyd.mit.edu> <4979CD93.5040503@gnu.org> Reply-To: Chong Yidong , 1990@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1232827437 25273 80.91.229.12 (24 Jan 2009 20:03:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Jan 2009 20:03:57 +0000 (UTC) Cc: 1990@emacsbugs.donarmstrong.com, Kenichi Handa To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 24 21:05:05 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LQokX-0002Mc-8J for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jan 2009 21:05:01 +0100 Original-Received: from localhost ([127.0.0.1]:49478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQojF-0003E7-Cg for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jan 2009 15:03:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQojA-0003DY-QZ for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 15:03:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQoj8-0003CW-2D for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 15:03:36 -0500 Original-Received: from [199.232.76.173] (port=41469 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQoj7-0003CQ-R8 for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 15:03:33 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40928) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQoj7-0004Wx-5M for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 15:03:33 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0OK3SZr026339; Sat, 24 Jan 2009 12:03:29 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0OJt4Sn024072; Sat, 24 Jan 2009 11:55:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 24 Jan 2009 19:55:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1990 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1990-submit@emacsbugs.donarmstrong.com id=B1990.123282641622748 (code B ref 1990); Sat, 24 Jan 2009 19:55:04 +0000 Original-Received: (at 1990) by emacsbugs.donarmstrong.com; 24 Jan 2009 19:46:56 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0OJkmmR022742 for <1990@emacsbugs.donarmstrong.com>; Sat, 24 Jan 2009 11:46:50 -0800 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 4A90857E196; Sat, 24 Jan 2009 14:47:16 -0500 (EST) In-Reply-To: <4979CD93.5040503@gnu.org> (Jason Rumney's message of "Fri, 23 Jan 2009 22:00:51 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 24 Jan 2009 15:03:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24468 Archived-At: Jason Rumney writes: >> However, there are several other places in that function that return >> with a Qnil, without doing this FONTSET_SET. Do matters improve if >> we do the same FONTSET_SET call before returning? > > It doesn't seem to help much, if at all. How about something like this? Does it improve performance noticeably? *** trunk/src/fontset.c.~1.150.~ 2009-01-08 06:46:23.000000000 -0500 --- trunk/src/fontset.c 2009-01-24 14:44:09.000000000 -0500 *************** *** 660,665 **** --- 660,668 ---- Lisp_Object rfont_def; Lisp_Object base_fontset; + if (EQ (Fchar_table_range (fontset, make_number (c)), Qt)) + return Qnil; + /* Try a font-group of FONTSET. */ rfont_def = fontset_find_font (fontset, c, face, id, 0); if (VECTORP (rfont_def))