all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Jason Rumney <jasonr@gnu.org>
Cc: 1990@emacsbugs.donarmstrong.com, Kenichi Handa <handa@m17n.org>
Subject: bug#1990: 23.0.60; Emacs trying too hard to find fonts that don't exist
Date: Sat, 24 Jan 2009 14:47:16 -0500	[thread overview]
Message-ID: <87d4ec1o6z.fsf@cyd.mit.edu> (raw)
In-Reply-To: <4979CD93.5040503@gnu.org> (Jason Rumney's message of "Fri, 23 Jan 2009 22:00:51 +0800")

Jason Rumney <jasonr@gnu.org> writes:

>> However, there are several other places in that function that return
>> with a Qnil, without doing this FONTSET_SET.  Do matters improve if
>> we do the same FONTSET_SET call before returning?
>
> It doesn't seem to help much, if at all.

How about something like this?  Does it improve performance noticeably?

*** trunk/src/fontset.c.~1.150.~	2009-01-08 06:46:23.000000000 -0500
--- trunk/src/fontset.c	2009-01-24 14:44:09.000000000 -0500
***************
*** 660,665 ****
--- 660,668 ----
    Lisp_Object rfont_def;
    Lisp_Object base_fontset;
  
+   if (EQ (Fchar_table_range (fontset, make_number (c)), Qt))
+     return Qnil;
+ 
    /* Try a font-group of FONTSET. */
    rfont_def = fontset_find_font (fontset, c, face, id, 0);
    if (VECTORP (rfont_def))







  reply	other threads:[~2009-01-24 19:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-23  5:04 bug#1990: 23.0.60; Emacs trying too hard to find fonts that don't exist Chong Yidong
2009-01-23 14:00 ` Jason Rumney
2009-01-24 19:47   ` Chong Yidong [this message]
2009-01-24 21:50     ` Juanma Barranquero
2009-01-24 21:55       ` Chong Yidong
2009-01-24 22:06         ` Juanma Barranquero
2009-01-25  5:22       ` Jason Rumney
2009-01-25 11:57         ` Juanma Barranquero
2009-01-26 11:46           ` Kenichi Handa
2009-01-26 12:02             ` Juanma Barranquero
2009-01-26  8:00     ` Kenichi Handa
2009-01-26 15:51       ` Chong Yidong
  -- strict thread matches above, loose matches on Subject: below --
2009-01-22 13:22 Jason Rumney
2009-01-24 13:28 ` Juanma Barranquero
2009-01-24 14:02   ` Jason Rumney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4ec1o6z.fsf@cyd.mit.edu \
    --to=cyd@stupidchicken.com \
    --cc=1990@emacsbugs.donarmstrong.com \
    --cc=handa@m17n.org \
    --cc=jasonr@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.