all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 3142@emacsbugs.donarmstrong.com
Subject: bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically
Date: Tue, 05 May 2009 14:03:44 +0300	[thread overview]
Message-ID: <87d4an95gv.fsf@mail.jurta.org> (raw)
In-Reply-To: <49FFE487.5000106@gmx.at> (martin rudalics's message of "Tue, 05 May 2009 09:02:31 +0200")

> +   :type '(choice
> + 	  (const :tag "sensibly" split-window-sensibly)
> + 	  (const :tag "vertically"
> + 		 (lambda (window)
> + 		   (when (window--splittable-p window)
> + 		     (with-selected-window window
> + 		       (split-window-vertically)))))
> + 	  (const :tag "horizontally"
> + 		 (lambda (window)
> + 		   (when (window--splittable-p window t)
> + 		     (with-selected-window window
> + 		       (split-window-horizontally)))))

Using lambdas in defcustoms is too ugly: it will put this long lambda code
to custom-set-variables in .emacs, and cause other problems.

I suggest defining new functions with the prefix `split-window-preferred-'
that will provide a hint for the user where they are intended to be used:

split-window-preferred-sensibly (window)
split-window-preferred-vertically (window)
split-window-preferred-horizontally (window)

-- 
Juri Linkov
http://www.jurta.org/emacs/






  reply	other threads:[~2009-05-05 11:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28  1:16 bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically Jared Finder
2009-04-28  6:29 ` martin rudalics
2009-04-28 17:21   ` Jared Finder
2009-04-28 22:48     ` Juri Linkov
2009-04-29  1:29       ` Stefan Monnier
2009-04-29  7:13       ` martin rudalics
2009-04-29  9:59         ` Juri Linkov
2009-04-29 12:40           ` martin rudalics
2009-04-29 13:50         ` bug#3142: 23.0.92; split-window-prefered-function should be able to usesplit-window-horizontally/split-window-vertically Drew Adams
2009-04-30  9:05           ` martin rudalics
2011-10-05 18:49             ` Glenn Morris
2011-10-05 22:11               ` Stefan Monnier
2009-04-29 15:26         ` bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically Stefan Monnier
2009-04-30  8:54           ` martin rudalics
2009-04-30 11:47             ` Juri Linkov
2009-04-30 18:20               ` Stefan Monnier
2009-05-01 11:54                 ` Juri Linkov
2009-05-01  8:33               ` martin rudalics
2009-05-01 11:52                 ` Juri Linkov
2009-05-02  8:40                   ` martin rudalics
2009-05-05  7:02           ` martin rudalics
2009-05-05 11:03             ` Juri Linkov [this message]
2009-05-06  1:41             ` Stefan Monnier
2009-05-06 16:21               ` martin rudalics
2009-05-06 19:04                 ` Stefan Monnier
2009-05-07  9:36                   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4an95gv.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=3142@emacsbugs.donarmstrong.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.