From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Why was diary-fancy-display-mode conditionalized? Date: Sun, 20 Sep 2009 21:06:13 +0200 Message-ID: <87d45l4esa.fsf@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253473621 8078 80.91.229.12 (20 Sep 2009 19:07:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Sep 2009 19:07:01 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 20 21:06:54 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MpRkK-0004er-Nv for ged-emacs-devel@m.gmane.org; Sun, 20 Sep 2009 21:06:53 +0200 Original-Received: from localhost ([127.0.0.1]:38661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpRkK-0008M4-8H for ged-emacs-devel@m.gmane.org; Sun, 20 Sep 2009 15:06:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpRkF-0008Ly-6N for emacs-devel@gnu.org; Sun, 20 Sep 2009 15:06:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpRkA-0008Lk-Bx for emacs-devel@gnu.org; Sun, 20 Sep 2009 15:06:46 -0400 Original-Received: from [199.232.76.173] (port=48483 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpRkA-0008Lh-5z for emacs-devel@gnu.org; Sun, 20 Sep 2009 15:06:42 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:54740) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpRk9-0004J6-LQ for emacs-devel@gnu.org; Sun, 20 Sep 2009 15:06:41 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1MpRk7-0004Ze-Aw for emacs-devel@gnu.org; Sun, 20 Sep 2009 21:06:39 +0200 Original-Received: from i59f54597.versanet.de ([89.245.69.151]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 20 Sep 2009 21:06:39 +0200 Original-Received: from stephen.berman by i59f54597.versanet.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 20 Sep 2009 21:06:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: i59f54597.versanet.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115484 Archived-At: As a result of this change: 2009-09-04 Glenn Morris [...] * calendar/diary-lib.el (diary-fancy-display): Only switch modes if necessary. diary-fancy-display-mode-hook is only run when there is no live buffer whose major mode is diary-fancy-display-mode; i.e., in effect, when there is no fancy diary buffer. Previously the hook was run unconditionally. Since calling diary-fancy-display when there is a live fancy diary buffer erases and rewrites the buffer, but does not change its major mode, this change means that, in this circumstance, any functions in diary-fancy-display-mode-hook will not be called, which can, e.g., result in a surprising change in the appearance of the fancy diary buffer (I have such a function in diary-fancy-display-mode-hook in my init file and was a victim of such surprise). This seems like a bug to me, and I think the simplest fix is to revert the change; or does it fix some other problem? If so, then how can the failure to run diary-fancy-display-mode-hook be repaired? Steve Berman