From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-devel@gnu.org
Subject: Why was diary-fancy-display-mode conditionalized?
Date: Sun, 20 Sep 2009 21:06:13 +0200 [thread overview]
Message-ID: <87d45l4esa.fsf@escher.local.home> (raw)
As a result of this change:
2009-09-04 Glenn Morris <rgm@gnu.org>
[...]
* calendar/diary-lib.el (diary-fancy-display): Only switch modes if
necessary.
diary-fancy-display-mode-hook is only run when there is no live buffer
whose major mode is diary-fancy-display-mode; i.e., in effect, when
there is no fancy diary buffer. Previously the hook was run
unconditionally. Since calling diary-fancy-display when there is a live
fancy diary buffer erases and rewrites the buffer, but does not change
its major mode, this change means that, in this circumstance, any
functions in diary-fancy-display-mode-hook will not be called, which
can, e.g., result in a surprising change in the appearance of the fancy
diary buffer (I have such a function in diary-fancy-display-mode-hook in
my init file and was a victim of such surprise). This seems like a bug
to me, and I think the simplest fix is to revert the change; or does it
fix some other problem? If so, then how can the failure to run
diary-fancy-display-mode-hook be repaired?
Steve Berman
next reply other threads:[~2009-09-20 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 19:06 Stephen Berman [this message]
2009-09-24 3:28 ` Why was diary-fancy-display-mode conditionalized? Glenn Morris
2009-09-24 7:21 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d45l4esa.fsf@escher.local.home \
--to=stephen.berman@gmx.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.