From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#4940: Avoiding loss of rcirc messages from the on disk log Date: Sun, 17 Jan 2010 19:01:33 -0500 Message-ID: <87d418uvqa.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263773451 32241 80.91.229.12 (18 Jan 2010 00:10:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jan 2010 00:10:51 +0000 (UTC) Cc: 4940@debbugs.gnu.org To: Ryan Yeske Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 18 01:10:43 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NWfCc-0000vb-Qx for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2010 01:10:43 +0100 Original-Received: from localhost ([127.0.0.1]:54891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWfCd-0007Tk-Mj for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jan 2010 19:10:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWfBS-0006gp-Th for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2010 19:09:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWfBN-0006Z9-Ab for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2010 19:09:29 -0500 Original-Received: from [199.232.76.173] (port=41644 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWfBN-0006Yn-1K for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2010 19:09:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48927) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NWfBM-0005lh-N4 for bug-gnu-emacs@gnu.org; Sun, 17 Jan 2010 19:09:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NWf4E-0007oa-FZ; Sun, 17 Jan 2010 19:02:02 -0500 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jan 2010 00:02:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 4940 X-Emacs-PR-Package: emacs,rcirc X-Emacs-PR-Keywords: Original-Received: via spool by 4940-submit@debbugs.gnu.org id=B4940.126377290030030 (code B ref 4940); Mon, 18 Jan 2010 00:02:02 +0000 Original-Received: (at 4940) by debbugs.gnu.org; 18 Jan 2010 00:01:40 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWf3q-0007oJ-Ae for submit@debbugs.gnu.org; Sun, 17 Jan 2010 19:01:38 -0500 Original-Received: from pantheon-po43.its.yale.edu ([130.132.50.104]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWf3p-0007oC-4G for 4940@debbugs.gnu.org; Sun, 17 Jan 2010 19:01:37 -0500 Original-Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po43.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0I01X7Q006703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 17 Jan 2010 19:01:33 -0500 Original-Received: by furry (Postfix, from userid 1000) id 4497CC05D; Sun, 17 Jan 2010 17:01:33 -0700 (MST) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.7 (--) Resent-Date: Sun, 17 Jan 2010 19:02:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34444 Archived-At: Hi Ryan, Could you review the patch from Giorgos Keramidas? Thanks. > The IRC buffers of "rcirc.el" use the auto-save mechanism to push log > messages on disk. This is a very good idea, since it avoids hitting the > disk for every single line of the IRC log. On busy channels it probably > saves a *lot* of time that would be spent waiting for messages to be > saved on disk. > Unfortunately, it also means that the simple action of killing an rcirc > buffer may lose some of the messages. Any messages still on the alist > `rcirc-log-alist' are still in memory and I've noticed that some of > these may not be written to the log files in `rcirc-log-directory'. diff -r e1381fd70a71 lisp/net/rcirc.el --- a/lisp/net/rcirc.el Fri Apr 03 03:02:01 2009 +0300 +++ b/lisp/net/rcirc.el Sat Oct 31 05:12:55 2009 +0200 -984,6 +984,8 If ALL is non-nil, update prompts in all (defun rcirc-kill-buffer-hook () "Part the channel when killing an rcirc buffer." (when (eq major-mode 'rcirc-mode) + (when (and rcirc-log-directory rcirc-log-alist) + (rcirc-log-write)) (rcirc-clean-up-buffer "Killed buffer"))) (defun rcirc-change-major-mode-hook ()