From: Chong Yidong <cyd@stupidchicken.com>
To: Ryan Yeske <rcyeske@gmail.com>
Cc: 4940@debbugs.gnu.org
Subject: bug#4940: Avoiding loss of rcirc messages from the on disk log
Date: Sun, 17 Jan 2010 19:01:33 -0500 [thread overview]
Message-ID: <87d418uvqa.fsf@stupidchicken.com> (raw)
In-Reply-To: <b6fx8ecfln.fsf@fencepost.gnu.org>
Hi Ryan,
Could you review the patch from Giorgos Keramidas? Thanks.
> The IRC buffers of "rcirc.el" use the auto-save mechanism to push log
> messages on disk. This is a very good idea, since it avoids hitting the
> disk for every single line of the IRC log. On busy channels it probably
> saves a *lot* of time that would be spent waiting for messages to be
> saved on disk.
> Unfortunately, it also means that the simple action of killing an rcirc
> buffer may lose some of the messages. Any messages still on the alist
> `rcirc-log-alist' are still in memory and I've noticed that some of
> these may not be written to the log files in `rcirc-log-directory'.
diff -r e1381fd70a71 lisp/net/rcirc.el
--- a/lisp/net/rcirc.el Fri Apr 03 03:02:01 2009 +0300
+++ b/lisp/net/rcirc.el Sat Oct 31 05:12:55 2009 +0200
<at> <at> -984,6 +984,8 <at> <at> If ALL is non-nil, update prompts in all
(defun rcirc-kill-buffer-hook ()
"Part the channel when killing an rcirc buffer."
(when (eq major-mode 'rcirc-mode)
+ (when (and rcirc-log-directory rcirc-log-alist)
+ (rcirc-log-write))
(rcirc-clean-up-buffer "Killed buffer")))
(defun rcirc-change-major-mode-hook ()
next parent reply other threads:[~2010-01-18 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b6fx8ecfln.fsf@fencepost.gnu.org>
2010-01-18 0:01 ` Chong Yidong [this message]
2011-01-22 16:26 ` bug#4940: Deniz Dogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d418uvqa.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=4940@debbugs.gnu.org \
--cc=rcyeske@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.