From: "Eric Schulte" <schulte.eric@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] comments exporting
Date: Mon, 14 Jun 2010 14:36:50 -0700 [thread overview]
Message-ID: <87d3vt47oq.fsf@gmail.com> (raw)
In-Reply-To: 87iq5ltm2g.wl%n.goaziou@gmail.com
Hi Nicolas,
Nicolas Goaziou <n.goaziou@gmail.com> writes:
>>>>>> Eric Schulte writes:
>
>> A potentially related issue,
>> The following org-mode snippet doesn't export correctly to latex,
>> presumably because of protection issues similar to those addressed in
>> your patch. Any ideas?
>
>> --8<---------------cut here---------------start------------->8---
>> ** comments not commented
>
>> # $some stuff
>> # some more stuff$ -- I should be a comment line
>> --8<---------------cut here---------------end--------------->8---
>
> Yes.
>
> Actually, the latex stuff is processed before taking care of comments
> (one of the last actions in every exporter). So the $...$ snippet is
> matched by org-latex and protected.
>
> This patch removes protection check from comment deletion : something
> in comment must not be exported anyway. I don't see any corner case
> right now.
>
Great. Thanks for the continuous flow of useful patches.
Not to look a gift patch in the mouth, but while this patch fixes the
above issue it looks like it introduces a new problem.
Before the patch the following
--8<---------------cut here---------------start------------->8---
** comments not commented
# $some stuff
# some more stuff$ -- I should be a comment line
1) a source block inside of an =enumerate=
#+source: plotxy
#+begin_src emacs-lisp :exports results
(message "I think so")
#+end_src
can cause problems
--8<---------------cut here---------------end--------------->8---
exports to
--8<---------------cut here---------------start------------->8---
\section{comments not commented}
\label{sec-1}
# some more stuff$ -- I should be a comment line
\begin{enumerate}
\item a source block inside of an \texttt{enumerate}
\begin{verbatim}
I think so
\end{verbatim}
can cause problems
\end{enumerate}
--8<---------------cut here---------------end--------------->8---
while after the patch it exports to
--8<---------------cut here---------------start------------->8---
\section{comments not commented}
\label{sec-1}
\begin{enumerate}
\item a source block inside of an \texttt{enumerate}
\#+source: plotxy
\#+results: plotxy
\begin{verbatim}
I think so
\end{verbatim}
can cause problems
\end{enumerate}
--8<---------------cut here---------------end--------------->8---
which is wrong in a different way.
>
>>> This patch looks great. Since it's >10 lines long, I must ask if you've
>>> signed the FSF papers for contributions to Emacs? If not is that
>>> something you're willing to do?
>
> I have sent the signed papers last Wednesday (I had to since my patch
> for org-babel-asymptote). I'm now waiting for their mail.
>
Oh, how forgetful of me, there's a todo in my agenda with your name on
it about checking up on the status of the FSF papers.
Thanks! -- Eric
>
> Regards,
>
> --
> Nicolas
next prev parent reply other threads:[~2010-06-14 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 23:25 [PATCH] lists and exportation to latex Nicolas Goaziou
2010-06-14 7:40 ` Nicolas Goaziou
2010-06-14 17:32 ` Eric Schulte
2010-06-14 18:10 ` Eric Schulte
2010-06-14 20:07 ` [PATCH] comments exporting Nicolas Goaziou
2010-06-14 21:36 ` Eric Schulte [this message]
2010-06-15 13:03 ` Nicolas Goaziou
2010-06-15 15:48 ` Eric Schulte
2010-06-15 16:32 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3vt47oq.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.