From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). Date: Wed, 14 Jul 2010 12:06:02 -0400 Message-ID: <87d3uqaw0l.fsf@kslab.red-bean.com> References: <87y6dydn6q.fsf@tux.homenetwork> <201006292126.15409.tassilo@member.fsf.org> <87iq51ehnv.fsf@tux.homenetwork> <201006292210.43121.tassilo@member.fsf.org> <87eifpegqx.fsf@tux.homenetwork> <87k4ozdq6b.fsf_-_@red-bean.com> <87aapu1wpu.fsf@tux.homenetwork> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279123796 10496 80.91.229.12 (14 Jul 2010 16:09:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 16:09:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 14 18:09:50 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4Wr-0001uf-Rg for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 18:09:50 +0200 Original-Received: from localhost ([127.0.0.1]:43202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ4Wr-00072i-98 for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 12:09:49 -0400 Original-Received: from [140.186.70.92] (port=40767 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ4TD-0005Qe-QL for emacs-devel@gnu.org; Wed, 14 Jul 2010 12:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZ4TA-0000vM-UI for emacs-devel@gnu.org; Wed, 14 Jul 2010 12:06:03 -0400 Original-Received: from osh-net-219-98.onshore.net ([66.146.219.98]:52996 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4TA-0000uv-RT for emacs-devel@gnu.org; Wed, 14 Jul 2010 12:06:00 -0400 Original-Received: from localhost ([127.0.0.1]:49177 helo=kslab.red-bean.com ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.72) (envelope-from ) id 1OZ4T9-0001P9-KQ; Wed, 14 Jul 2010 11:05:59 -0500 In-Reply-To: <87aapu1wpu.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 14 Jul 2010 07:03:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127296 Archived-At: Thierry Volpiatto writes: >> patch. You used (or kept) parameter names `point-only' and >> `read-only'; > >kept: point-only >added: read-only Thanks (I was just writing tersely in my email). >> I changed those to `no-file' and `no-context', to describe what they are > >Yes nice these names are better. Glad you agree! >I will try to retrieve the patch for Emacs, if i don't retrieve it, it >would be good you commit the changes without the C-w feature and i will >create a patch that apply on top of this.(I really don't remember yet >what i changed to make that working, need to check my logs and >bookmark-extensions.el) I have committed the changes, including the changes to Gnus (see Bzr revs below). Please post the C-w patch and I will apply that too. Thanks! -Karl ------------------------------------------------------------ revno: 100820 revision-id: kfogel@red-bean.com-20100714160253-bbfda9e1g7myj1o8 parent: kfogel@red-bean.com-20100714155754-n3k71gay91l4vetv committer: Karl Fogel branch nick: trunk timestamp: Wed 2010-07-14 12:02:53 -0400 message: Allow bookmarks to be set from Gnus Article buffers (Bug #5975). Patch applied (with minor tweaks) by Karl Fogel. Note this leaves C-w still not working correctly from Article buffers; Thierry's patch to fix that will be applied after this. * lisp/gnus/gnus-art.el (bookmark-make-record-function): New local variable. * lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Allow setting from article buffer. (gnus-summary-bookmark-jump): Maybe jump to article buffer. ------------------------------------------------------------ revno: 100819 revision-id: kfogel@red-bean.com-20100714155754-n3k71gay91l4vetv parent: kfogel@red-bean.com-20100714155426-vnlagemntoe30nu6 committer: Karl Fogel branch nick: trunk timestamp: Wed 2010-07-14 11:57:54 -0400 message: Preparation for setting bookmarks in Gnus article buffers (Bug#5975). * lisp/bookmark.el (bookmark-make-record-default): Allow unneeded information to be omitted from the record. Adjust declarations and calls: * lisp/info.el (bookmark-make-record-default): Adjust declaration. (Info-bookmark-make-record): Adjust call. * lisp/woman.el (bookmark-make-record-default): Adjust declaration. (woman-bookmark-make-record): Adjust call. * lisp/man.el (bookmark-make-record-default): Adjust declaration. (Man-bookmark-make-record): Adjust call. * lisp/image-mode.el (bookmark-make-record-default): Adjust declaration. * lisp/doc-view.el (bookmark-make-record-default): Adjust declaration. * lisp/gnus/gnus-sum.el (bookmark-make-record-default): Adjust declaration. ------------------------------------------------------------