From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: "ignore Y" in make_lispy_event
Date: Fri, 26 Nov 2010 10:47:12 -0500 [thread overview]
Message-ID: <87d3psw0hr.fsf@stupidchicken.com> (raw)
In-Reply-To: <83bp5c6vzn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Nov 2010 15:43:40 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> A comment in keyboard.c:make_lispy_event says:
>
> /* For mode line and header line clicks, return X relative to
> the left window edge; ignore Y. Use mode_line_string to look
> for a string on the click position. */
>
> The code below that, introduced in revno 102413, indeed "ignores Y",
> in that it leaves yret at its initial zero value. This breaks mouse
> clicks on the mode line that pop up menus via x-popup-menu: the menu
> is popped at the top of the frame/window, instead of at the place of
> the click.
>
> Chong, did you have good reasons to "ignore Y"? If not, the simple
> patch below restores the correct behavior of the popup menus:
I was working using the Elisp manual as a spec:
X, Y
These are the pixel coordinates of the click, relative to the
top left corner of WINDOW, which is `(0 . 0)'. For the mode
or header line, Y does not have meaningful data. For the
vertical line, X does not have meaningful data.
If there is existing code that relies on undocumented behavior, then we
should indeed restore the old behavior, and document it in the manual.
next prev parent reply other threads:[~2010-11-26 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 13:43 "ignore Y" in make_lispy_event Eli Zaretskii
2010-11-26 15:47 ` Chong Yidong [this message]
2010-11-26 16:11 ` Eli Zaretskii
2010-11-26 18:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3psw0hr.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.