From: Stephen Berman <stephen.berman@gmx.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 9006@debbugs.gnu.org
Subject: bug#9006: 24.0.50; Abort in unshow_buffer/kill-buffer
Date: Sun, 10 Jul 2011 12:25:23 +0200 [thread overview]
Message-ID: <87d3hiqvos.fsf@escher.fritz.box> (raw)
In-Reply-To: <4E1969EE.7040201@gmx.at> (martin rudalics's message of "Sun, 10 Jul 2011 10:59:26 +0200")
On Sun, 10 Jul 2011 10:59:26 +0200 martin rudalics <rudalics@gmx.at> wrote:
>> I just encountered a bad effect that I assume is caused by this change,
>> since it didn't happen before:
>
> Before means before the change that sets w->pointm?
Yes
> Are you sure it's
> not related to upgrading to the new window code?
Yes; I don't see the bad effect with my post-new-window-code build
without the w->pointm change.
>> when I type `h'
>> (gnus-summary-select-article-buffer) in the Gnus Summary buffer, this
>> splits the window and selects the Article buffer as it's supposed to,
>> but in the Summary buffer point simultaneously moves to point-min; it's
>> supposed to stay put. The same thing happens when I have split windows
>> with the Summary and Article buffer and in the former type C-x o
>> (other-window). I haven't been able to reproduce this with other
>> buffers, but only with Gnus Summary. Still no abort, but this effect
>> means the fix -- if it is one -- at least needs further tuning.
>
> Just to make sure: This does not happen with the w->pointm hack?
Correct.
> If so,
> that is if it does not happen with the w->pointm hack, then it's
> obviously what I mentioned in the last post: We set window-point to 1
> for the temporary buffer but we don't reset it back to the old buffer's
> position upon exiting `vertical-motion'.
Is window-point set to 1 as a side effect of making the temporary
buffer?
> Rather _you_ did set the old
> buffer's window point to 1 and it stays put there when you set w->buffer
> to old_buffer upon exiting `vertical-motion'.
Do you have a suggestion how to reset point?
> (Note that
> `vertical-motion' gets called by `split-window-above-each-other'.)
I don't see point moving when the window is split, only when -- with an
already split window -- the other window is selected. Indeed, stepping
through both gnus-summary-select-article-buffer and other-window, I see
point move upon the call to select-window. The comment at the top of
select_window seems relevant:
/* If select_window is called with inhibit_point_swap non-zero it will
not store point of the old selected window's buffer back into that
window's pointm slot. This is needed by Fset_window_configuration to
avoid that the display routine is called with selected_window set to
Qnil causing a subsequent crash. */
However, when I set a conditional breakpoint inhibit_point_swap!=0 this
did not interrupt execution, whereas with breakpoint select_window,
execution interrupts with inhibit_point_swap == 0, so I guess I don't
understand the comment.
Steve Berman
next prev parent reply other threads:[~2011-07-10 10:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 23:20 bug#9006: 24.0.50; Abort in unshow_buffer/kill-buffer Stephen Berman
2011-07-06 9:25 ` martin rudalics
2011-07-06 19:19 ` Stephen Berman
2011-07-07 8:23 ` martin rudalics
2011-07-07 9:32 ` Stephen Berman
2011-07-07 15:47 ` martin rudalics
2011-07-08 23:03 ` Stephen Berman
2011-07-09 8:44 ` martin rudalics
2011-07-09 11:57 ` Stephen Berman
2011-07-09 13:01 ` martin rudalics
2011-07-09 16:27 ` Stephen Berman
2011-07-09 16:54 ` Stephen Berman
2011-07-10 8:59 ` martin rudalics
2011-07-10 10:25 ` Stephen Berman [this message]
2011-07-10 13:30 ` martin rudalics
2011-07-10 20:31 ` Stephen Berman
2011-07-11 19:14 ` martin rudalics
2011-07-11 20:04 ` Stephen Berman
2011-07-12 8:36 ` martin rudalics
2011-07-12 8:51 ` Stephen Berman
2011-07-13 6:53 ` Stephen Berman
2011-07-13 7:24 ` Eli Zaretskii
2011-07-13 8:00 ` Stephen Berman
2011-07-13 10:03 ` Eli Zaretskii
2011-07-13 11:40 ` Stephen Berman
2011-07-13 8:37 ` martin rudalics
2011-07-13 10:05 ` Eli Zaretskii
2011-07-13 11:54 ` martin rudalics
2011-07-13 12:20 ` Stephen Berman
2011-07-13 11:39 ` Stephen Berman
2011-07-14 8:35 ` martin rudalics
2011-07-15 21:05 ` Stephen Berman
2011-07-10 8:58 ` martin rudalics
2011-07-09 12:44 ` Stephen Berman
2011-07-09 13:01 ` martin rudalics
2011-07-09 17:31 ` Eli Zaretskii
2011-07-10 8:59 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3hiqvos.fsf@escher.fritz.box \
--to=stephen.berman@gmx.net \
--cc=9006@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.