From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Christoph Scholtes <cschol2112@googlemail.com>,
Juanma Barranquero <lekktu@gmail.com>,
9873@debbugs.gnu.org
Subject: bug#9873: 24.0.90; dired - window changes size when trying to delete more than one file
Date: Thu, 03 Nov 2011 21:42:41 +0200 [thread overview]
Message-ID: <87d3d9hu1a.fsf@mail.jurta.org> (raw)
In-Reply-To: <4EAE7823.1020303@gmx.at> (martin rudalics's message of "Mon, 31 Oct 2011 11:27:47 +0100")
>> + pop-up-frames)
>
> There should be no need to bind this to nil.
I agree it's unnecessary. Below is a new patch without `pop-up-frames':
=== modified file 'lisp/window.el'
--- lisp/window.el 2011-11-02 09:39:18 +0000
+++ lisp/window.el 2011-11-03 19:34:58 +0000
@@ -4853,6 +4853,23 @@ (defun display-buffer-pop-up-window (buf
(set-window-prev-buffers window nil)
window)))
+(defun display-buffer-pop-up-window-below (buffer alist)
+ "Display BUFFER by popping up a new window below the selected window."
+ (let (
+ ;; Stay within the confines of the initial window.
+ ;; Don't resize other windows. (Bug#1806 Bug#9873)
+ (window-nest t)
+ (split-window-preferred-function
+ (lambda (window)
+ (or (and (let ((split-height-threshold 0))
+ (window-splittable-p (selected-window)))
+ ;; Try to split the selected window vertically if
+ ;; that's possible. (Bug#1806)
+ (split-window-below))
+ ;; Otherwise, try to split WINDOW sensibly.
+ (split-window-sensibly window)))))
+ (display-buffer-pop-up-window buffer alist)))
+
(defun display-buffer--maybe-pop-up-frame-or-window (buffer alist)
"Try displaying BUFFER based on `pop-up-frames' or `pop-up-windows'.
next prev parent reply other threads:[~2011-11-03 19:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 2:03 bug#9873: 24.0.90; dired - window changes size when trying to delete more than one file Christoph Scholtes
2011-10-26 2:16 ` Juanma Barranquero
2011-10-26 2:50 ` Christoph Scholtes
2011-10-26 2:52 ` Juanma Barranquero
2011-10-26 9:22 ` martin rudalics
2011-10-26 11:08 ` Eli Zaretskii
2011-10-26 14:22 ` martin rudalics
2011-10-26 18:30 ` Eli Zaretskii
2011-10-27 9:51 ` martin rudalics
2011-10-27 10:23 ` Eli Zaretskii
2011-10-27 13:15 ` martin rudalics
2011-10-27 3:39 ` Christoph Scholtes
2011-10-27 9:53 ` martin rudalics
2011-10-28 8:12 ` Juri Linkov
2011-10-28 17:16 ` martin rudalics
2011-10-31 10:11 ` Juri Linkov
2011-10-31 10:27 ` martin rudalics
2011-11-03 19:42 ` Juri Linkov [this message]
2012-10-04 18:31 ` Juri Linkov
2012-10-04 18:51 ` martin rudalics
2012-10-04 19:40 ` Juri Linkov
2012-10-05 7:03 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3d9hu1a.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=9873@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
--cc=lekktu@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.