From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.bugs Subject: bug#11586: mkstemp failure diagnostic lacks directory name Date: Wed, 30 May 2012 12:28:29 +0200 Message-ID: <87d35mt12q.fsf@rho.meyering.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338373792 3016 80.91.229.3 (30 May 2012 10:29:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 May 2012 10:29:52 +0000 (UTC) To: 11586@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 30 12:29:49 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZgA1-0003lZ-Al for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 May 2012 12:29:49 +0200 Original-Received: from localhost ([::1]:60353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZgA0-00051x-Tq for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 May 2012 06:29:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg9t-00050O-Jd for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:29:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg9m-00028j-UD for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:29:41 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg9m-00028d-Qo for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:29:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SZgBC-0003cb-GE for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 May 2012 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11586 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133837384313889 (code B ref -1); Wed, 30 May 2012 10:31:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 May 2012 10:30:43 +0000 Original-Received: from localhost ([127.0.0.1]:49527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZgAt-0003by-1r for submit@debbugs.gnu.org; Wed, 30 May 2012 06:30:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54243) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZgAX-0003bN-Eq for submit@debbugs.gnu.org; Wed, 30 May 2012 06:30:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg90-00023F-ML for submit@debbugs.gnu.org; Wed, 30 May 2012 06:28:47 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:41656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg90-00023A-IS for submit@debbugs.gnu.org; Wed, 30 May 2012 06:28:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg8u-0004wG-BQ for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:28:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg8p-00022J-CQ for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:28:39 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:42515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg8p-00022E-94 for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:28:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36638) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1SZg8o-000745-LW for bug-emacs@gnu.org; Wed, 30 May 2012 06:28:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg8l-00021f-LX for bug-emacs@gnu.org; Wed, 30 May 2012 06:28:33 -0400 Original-Received: from mx.meyering.net ([88.168.87.75]:35632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg8l-00021L-EQ for bug-emacs@gnu.org; Wed, 30 May 2012 06:28:31 -0400 Original-Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 517376009D for ; Wed, 30 May 2012 12:28:29 +0200 (CEST) Original-Lines: 61 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60505 Archived-At: In emacs I tried to filter a section of an input file through a pipe and got this diagnostic: byte-code: Failed to open temporary file: No such file or directory, emacsXXXXXX Knowing it's due to mkstemp failure, most would suspect that /tmp is missing. But I set TMPDIR to a different private directory for each shell, and for me it means that the parent shell's temporary directory had been removed. Oops. It should be easy to work around simply by recreating that directory, but the diagnostic doesn't include the directory name. Sure, I was able to work around it by inspecting emacs's view of $TMPDIR, but I shouldn't have had to do that. With the tiny patch below, I now get a diagnostic like this: byte-code: Failed to open temporary file: No such file or directory, /t/jt-toGrGn/emacs3gdoKc >From a389e755b74e048a34628b4f5ccad9f244e99cc3 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 30 May 2012 12:25:58 +0200 Subject: [PATCH] diagnose mkstemp failure with full file name * callproc.c (Fcall_process_region): Diagnose mkstemp failure using the full, expanded name, including the directory part, not just the basename template. --- src/ChangeLog | 6 ++++++ src/callproc.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index edf68a5..5d9e86e 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,9 @@ +2012-05-30 Jim Meyering + + * callproc.c (Fcall_process_region): Diagnose mkstemp failure using + the full, expanded name, including the directory part, not just + the basename template. + 2012-05-30 Paul Eggert * alloc.c, lisp.h (make_pure_vector): Now static. diff --git a/src/callproc.c b/src/callproc.c index f7c9971..976d306 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -1015,7 +1015,7 @@ usage: (call-process-region START END PROGRAM &optional DELETE BUFFER DISPLAY &r UNBLOCK_INPUT; if (fd == -1) report_file_error ("Failed to open temporary file", - Fcons (Vtemp_file_name_pattern, Qnil)); + Fcons (build_string (tempfile), Qnil)); else close (fd); } -- 1.7.10.2.605.gbefc5ed