From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#11541: 24.0.97; Crash when visiting file on OS X 10.7.3 Date: Thu, 31 May 2012 14:52:12 +0800 Message-ID: <87d35kj10j.fsf@gnu.org> References: <4fbb6a82.d491cc0a.42d6.3965@mx.google.com> <878vgbozcz.fsf@gnu.org> <877gvu9wun.fsf@gnu.org> <874nqyyn83.fsf@gnu.org> <87d35lyen5.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338447166 14044 80.91.229.3 (31 May 2012 06:52:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 31 May 2012 06:52:46 +0000 (UTC) Cc: 11541@debbugs.gnu.org To: Florian Ebeling Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 31 08:52:45 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZzFP-0000rR-N2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 May 2012 08:52:39 +0200 Original-Received: from localhost ([::1]:55755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZzFP-0000tc-IH for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 May 2012 02:52:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZzFM-0000tA-Mf for bug-gnu-emacs@gnu.org; Thu, 31 May 2012 02:52:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZzFG-0002ws-Ay for bug-gnu-emacs@gnu.org; Thu, 31 May 2012 02:52:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZzFG-0002wb-7P for bug-gnu-emacs@gnu.org; Thu, 31 May 2012 02:52:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SZzGk-0005EU-5n for bug-gnu-emacs@gnu.org; Thu, 31 May 2012 02:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 May 2012 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11541 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: Original-Received: via spool by 11541-submit@debbugs.gnu.org id=B11541.133844724020107 (code B ref 11541); Thu, 31 May 2012 06:54:02 +0000 Original-Received: (at 11541) by debbugs.gnu.org; 31 May 2012 06:54:00 +0000 Original-Received: from localhost ([127.0.0.1]:51213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZzGg-0005EE-Fq for submit@debbugs.gnu.org; Thu, 31 May 2012 02:54:00 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:50995 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZzGb-0005E0-68 for 11541@debbugs.gnu.org; Thu, 31 May 2012 02:53:57 -0400 Original-Received: from [155.69.19.37] (port=58407 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZzF4-0002Dk-9v; Thu, 31 May 2012 02:52:18 -0400 In-Reply-To: (Florian Ebeling's message of "Wed, 30 May 2012 16:39:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60558 Archived-At: Florian Ebeling writes: > It still stops at the same location, which is 531 after the patch. > > 524 if (!FONT_SPEC_P (font_spec)) > 525 abort (); > 526 > 527 fkeys = [NSMutableSet setWithArray: [[fdesc fontAttributes] > allKeys]]; > 528 if (isMatch) > 529 [fkeys removeObject: NSFontFamilyAttribute]; > 530 > 531 matchingDescs = [fdesc matchingFontDescriptorsWithMandatoryKeys: > fkeys]; > (gdb) p font_spec > $1 = 140734799760960 > (gdb) xtype > Lisp_Int0 Does the following patch fix the crash? === modified file 'src/nsfont.m' *** src/nsfont.m 2012-02-10 18:58:48 +0000 --- src/nsfont.m 2012-05-31 06:51:00 +0000 *************** *** 157,164 **** fdesc = [fdesc fontDescriptorWithFamily: family]; } - [fdAttrs release]; - [tdict release]; return fdesc; } --- 157,162 ----