From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 12615@debbugs.gnu.org, Harald Hanche-Olsen <hanche@math.ntnu.no>
Subject: bug#12615: 24.2.50; Non-ignored case in insert-char
Date: Sun, 30 Dec 2012 00:56:05 +0200 [thread overview]
Message-ID: <87d2xsxy9q.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvwqyxn7zh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 10 Oct 2012 20:56:00 -0400")
>> Some observations: C-x 8 C-m is bound to insert-char, a C function.
>> And insert-char calls read-char-by-name, which let-binds
>> completion-ignore-case to t. The clear intention is that unicode name
>> searches should always be case insensitive, and this seems always to
>> be the case if completion-ignore-case is not buffer local.
>
> Indeed, a buffer-local setting of completion-ignore-case can
> bring surprises. I think the patch below will fix this problem for this
> particular case.
I just stumbled upon the case where this fix causes the regression:
typing `C-x 8 RET *acc TAB' results in "[No match]".
I don't know why this case disobeys the let-binding of
`completion-ignore-case' and whether a simpler fix is possible,
but at least this patch fixes it for the emacs-24 branch:
=== modified file 'lisp/international/mule-cmds.el'
--- lisp/international/mule-cmds.el 2012-10-11 20:05:47 +0000
+++ lisp/international/mule-cmds.el 2012-12-29 22:45:12 +0000
@@ -2946,10 +2946,12 @@ (defun read-char-by-name (prompt)
point or a number in hash notation, e.g. #o21430 for octal,
#x2318 for hex, or #10r8984 for decimal."
(let ((input
+ (minibuffer-with-setup-hook
+ (lambda ()
+ (set (make-local-variable 'completion-ignore-case) t))
(completing-read
prompt
(lambda (string pred action)
- (let ((completion-ignore-case t))
(if (eq action 'metadata)
'(metadata (category . unicode-name))
(complete-with-action action (ucs-names) string pred)))))))
next prev parent reply other threads:[~2012-12-29 22:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:36 bug#12615: 24.2.50; Non-ignored case in insert-char Harald Hanche-Olsen
2012-10-10 18:03 ` Harald Hanche-Olsen
2012-10-10 19:30 ` Andreas Schwab
2012-10-10 21:31 ` Glenn Morris
2012-10-11 6:32 ` Harald Hanche-Olsen
2012-10-11 0:56 ` Stefan Monnier
2012-10-11 6:37 ` Harald Hanche-Olsen
2012-10-11 20:12 ` Stefan Monnier
2012-12-29 22:56 ` Juri Linkov [this message]
2013-01-04 0:13 ` Juri Linkov
2013-01-08 0:45 ` Juri Linkov
2013-01-08 3:19 ` Stefan Monnier
2013-01-09 0:20 ` Juri Linkov
2013-01-09 2:41 ` Stefan Monnier
2013-01-10 0:24 ` Juri Linkov
2013-01-10 2:50 ` Stefan Monnier
2020-09-13 16:33 ` Lars Ingebrigtsen
2022-04-22 12:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2xsxy9q.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=12615@debbugs.gnu.org \
--cc=hanche@math.ntnu.no \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.