From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#13321: 24.3.0.50; Gmail error when replying from Gnus to github Date: Sat, 23 Feb 2013 11:06:19 +0100 Organization: Emacs Helm Message-ID: <87d2vr5opw.fsf@gmail.com> References: <87a9surugk.fsf@gmail.com> <87zk0rffsg.fsf@gmail.com> <87mwwqg78u.fsf@gmail.com> <87ip7eg43v.fsf@gmail.com> <87y5g4gp2c.fsf@gmail.com> <87txp5ocvp.fsf@gmail.com> <877gm1r4lv.fsf@gmail.com> <87fw0pihfz.fsf@gmail.com> <877gm0iyzj.fsf@gmail.com> <87621kek7h.fsf@gmail.com> <87hal35tox.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1361614067 2185 80.91.229.3 (23 Feb 2013 10:07:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Feb 2013 10:07:47 +0000 (UTC) To: 13321@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 23 11:08:09 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U9C1S-000212-OG for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2013 11:08:02 +0100 Original-Received: from localhost ([::1]:58329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9C18-0007vD-4T for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2013 05:07:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9C15-0007uv-C3 for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:07:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9C12-0001oF-Fo for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:07:39 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9C12-0001oB-CA for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:07:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U9C2Q-000325-I1; Sat, 23 Feb 2013 05:09:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87a9surugk.fsf@gmail.com> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 23 Feb 2013 10:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13321 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136161410611612 (code B ref -1); Sat, 23 Feb 2013 10:09:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Feb 2013 10:08:26 +0000 Original-Received: from localhost ([127.0.0.1]:45106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U9C1p-00031F-Og for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:08:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52301) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U9C1l-000316-Lf for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:08:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9C0G-0001is-BE for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:06:54 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:39671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9C0G-0001io-8v for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:06:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9C0E-0007tj-FH for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:06:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9C03-0001hS-5R for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:06:46 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:36673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9C02-0001hO-VE for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:06:35 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1U9C0J-0000WY-63 for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 11:06:51 +0100 Original-Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Feb 2013 11:06:51 +0100 Original-Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Feb 2013 11:06:51 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 70 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:cOZ5o/HfqvB/JxSvrqOqQojc3l4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71698 Archived-At: Thierry Volpiatto writes: > Katsumi Yamaoka writes: > >> thierry.volpiatto@gmail.com wrote: >>> Katsumi Yamaoka writes: >>>> Please let me say that a wide reply doesn't contain the author >>>> of an original mail in the recipient list is a bug. To exclude >>>> an invalid address from a wide reply is not a feature; >> >>> It is not excluded in the patch, it is added to "cc" only if "wide" is >>> specified. >> [...] >>> Please have a look at the mail examples I sent in other posts. >> >> Hm, I haven't gotten it yet. Could you try replying to a mail >> attached in this message as well (copy it to a mail group and do >> F)? >> >> [...] >>> The point is that with the patch I sent + the headers of the rejected >>> mail and the original mail where I reply to, you will be able to >>> understand what happen and fix it. >> >> Ok, I'll surely try it. > > And you can probaly get rid of this while loop too by removing > duplicates in first place: > > - (message-tokenize-header recipients))) > - ;; Remove all duplicates. > - (let ((s recipients)) > - (while s > - (let ((address (car (pop s)))) > - (while (assoc address s) > - (setq recipients (delq (assoc address s) recipients) > - s (delq (assoc address s) s)))))) > + ;; Remove all duplicates. > + (loop with recip for mess in (message-tokenize-header recipients) > + unless (member mess recip) collect mess into recip > + finally return recip))) > > NOTE: `remove-duplicates' can't be used because you require cl at compile > time only. And while we are at it this one also can be simpler: - (let ((plain-addrs (mapcar 'car recipients)) - subaddrs recip) - (while plain-addrs - (setq subaddrs (assoc (car plain-addrs) - message-hierarchical-addresses) - plain-addrs (cdr plain-addrs)) - (when subaddrs - (setq subaddrs (cdr subaddrs)) - (while subaddrs - (setq recip (assoc (car subaddrs) recipients) - subaddrs (cdr subaddrs)) - (if recip - (setq recipients (delq recip recipients)))))))) + (setq recipients + (loop for (r . a) in recipients + for assoc = (cdr (assoc r message-hierarchical-addresses)) + when assoc append assoc into recip + unless (member r recip) collect (cons r a) into results + finally return (cdr results)))) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997