From: Jambunathan K <kjambunathan@gmail.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 13687@debbugs.gnu.org
Subject: bug#13687: /srv/bzr/emacs/trunk r111878: * lisp/replace.el(read-regexp): Let-bind `default' to the first
Date: Sat, 09 Mar 2013 14:17:22 +0530 [thread overview]
Message-ID: <87d2v9rmcl.fsf@gmail.com> (raw)
In-Reply-To: <8738w5n3rg.fsf@gmail.com> (Jambunathan K.'s message of "Sat, 09 Mar 2013 00:00:11 +0530")
[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]
Jambunathan K <kjambunathan@gmail.com> writes:
> "Drew Adams" <drew.adams@oracle.com> writes:
>
>> E.g., in the code I cited, if a user does not want the same defaulting
>> behavior for commands `occur', `how-many', etc., she can set option
>> `search/replace-default-fn' to a function that distinguishes them
>> (e.g., using `this-command', as Jambunathan suggested).
>
> Interesting suggestion there.
>
> This makes me think that there is no need for multiple
> `hi-lock-read-regexp-defaults-function' and a separate
> `occur-read-regexp-defaults-function' etc. But a single
> `read-regexp-defaults-function' that cases on `this-command'.
>
> The function can return a symbol token like `t' for `this-command's
> which it doesn't want to meddle with but return nil or a regexp or list
> of regexps for commands it wants to insinuate.
>
> Is there any problem with this `read-regexp-defaults-function'
> approach?
EXPERIMENTAL and ABANDONED PATCH
Use of `this-command' is very fragile and flaky. Consider
`multi-occur-in-matching-buffers' which does multiple `read-regexp' -
one for the buffers and one for the actual regexp. It is not possible
to return a two different regexps for the same `this-command'.
Interestingly, I am attaching a long from *Messages* buffer and it looks
like `this-command' is not reliable (Do you see `exit-minibuffer' in the
logs.)
So `this-command' could work for simple commands like highlighting
commands but will be flaky to be applied in general.
Anyways good to experiment and see where an idea takes us...
----------------------------------------------------------------
Customization
(custom-set-variables
'(read-regexp-user-defaults
(quote ((highlight-regexp find-tag-default-as-regexp)
(highlight-phrase find-tag-default)
(multi-occur-in-matching-buffers find-tag-default)))))
----------------------------------------------------------------
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: replace.el.patch --]
[-- Type: text/x-diff, Size: 2023 bytes --]
=== modified file 'lisp/replace.el'
--- lisp/replace.el 2013-03-08 04:18:16 +0000
+++ lisp/replace.el 2013-03-09 08:23:57 +0000
@@ -580,6 +580,39 @@ of `history-length', which see.")
(defvar occur-collect-regexp-history '("\\1")
"History of regexp for occur's collect operation")
+(defcustom read-regexp-user-defaults nil
+ ""
+ :type '(choice
+ (const :tag "Use system defaults" nil)
+ (repeat :tag "Per-command defaults"
+ (list (radio :tag "Command"
+ (function-item highlight-regexp)
+ (function-item highlight-phrase)
+ (function-item highlight-lines-matching-regexp)
+ (function :tag "Command"))
+ (choice :tag "Function to retrieve the regexp"
+ (const :tag "Use no defaults" nil)
+ (const :tag "Use system defaults" t)
+ (radio
+ (function-item find-tag-default-as-regexp)
+ (function-item find-tag-default)
+ (function-item :tag "Regexp history"
+ (lambda nil
+ "Use regexp history."
+ (car regexp-history)))
+ function)))))
+ :group 'matching
+ :version "24.4")
+
+(defun read-regexp-defaults ()
+ (if (not read-regexp-user-defaults) t
+ (let ((user-default (assoc this-command read-regexp-user-defaults)))
+ (pcase user-default
+ (`(,cmd ,(and (pred functionp) getter))
+ (funcall getter))
+ (`nil nil)
+ (_ t)))))
+
(defun read-regexp (prompt &optional defaults history)
"Read and return a regular expression as a string.
When PROMPT doesn't end with a colon and space, it adds a final \": \".
@@ -597,6 +630,11 @@ and the last replacement regexp.
Optional arg HISTORY is a symbol to use for the history list.
If HISTORY is nil, `regexp-history' is used."
+ (let ((user-defaults (read-regexp-defaults)))
+ (unless (eq user-defaults t)
+ (setq defaults user-defaults)
+ (message "cmd: %s defaults: %S" this-command defaults)))
+
(let* ((default (if (consp defaults) (car defaults) defaults))
(suggestions (if (listp defaults) defaults (list defaults)))
(suggestions
[-- Attachment #3: Type: text/plain, Size: 431 bytes --]
----------------------------------------------------------------
*Messages*
Global-Hi-Lock mode enabled
Mark saved where search started
cmd: highlight-regexp defaults: "\\_<hi-yellow\\_>"
cmd: highlight-regexp defaults: "\\_<defface\\_>"
cmd: highlight-phrase defaults: "min-colors"
cmd: multi-occur-in-matching-buffers defaults: ":background"
cmd: exit-minibuffer defaults: nil
Searched 1 buffer; 10 matches for `yellow'
next prev parent reply other threads:[~2013-03-09 8:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1UA5QC-0006Vm-Qb@vcs.savannah.gnu.org>
[not found] ` <877glsyecw.fsf@gmail.com>
2013-02-28 18:12 ` bug#13687: /srv/bzr/emacs/trunk r111878: * lisp/replace.el (read-regexp): Let-bind `default' to the first Juri Linkov
2013-03-03 9:31 ` Juri Linkov
2013-03-06 18:00 ` Jambunathan K
2013-03-08 13:02 ` Jambunathan K
2013-03-08 15:29 ` bug#13687: /srv/bzr/emacs/trunk r111878: * lisp/replace.el(read-regexp): " Drew Adams
2013-03-08 16:53 ` Jambunathan K
2013-03-08 17:10 ` Drew Adams
2013-03-08 17:27 ` Jambunathan K
2013-03-08 17:28 ` Juri Linkov
2013-03-08 18:16 ` Drew Adams
2013-03-08 18:30 ` Jambunathan K
2013-03-08 18:53 ` Drew Adams
2013-03-08 19:03 ` Jambunathan K
2013-03-08 21:08 ` Drew Adams
2013-03-09 8:47 ` Jambunathan K [this message]
2013-03-09 15:08 ` Drew Adams
2013-03-09 16:21 ` Jambunathan K
2013-03-09 16:37 ` Drew Adams
2013-03-09 16:59 ` Jambunathan K
2013-03-09 17:14 ` Drew Adams
2013-03-09 17:25 ` Jambunathan K
2013-03-09 17:55 ` Drew Adams
2013-03-10 18:28 ` Juri Linkov
2013-03-18 7:24 ` Jambunathan K
2013-03-04 5:46 ` bug#13687: /srv/bzr/emacs/trunk r111878: * lisp/replace.el (read-regexp): " Jambunathan K
2013-03-04 9:28 ` Juri Linkov
2013-03-06 18:03 ` Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2v9rmcl.fsf@gmail.com \
--to=kjambunathan@gmail.com \
--cc=13687@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.