From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function Date: Wed, 13 Mar 2013 15:43:48 +0100 Organization: Emacs Helm Message-ID: <87d2v39x7f.fsf@gmail.com> References: <87liaam7dh.fsf@gmail.com> <87hakym6il.fsf@gmail.com> <87d2vmm3nh.fsf@gmail.com> <871uc1ese2.fsf@gmail.com> <87k3ptbtoj.fsf@gmail.com> <877gltm05y.fsf@gmail.com> <87vc9cgr2i.fsf@gmail.com> <87zjyny54l.fsf@gmail.com> <87ppzjj5va.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363185910 16666 80.91.229.3 (13 Mar 2013 14:45:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Mar 2013 14:45:10 +0000 (UTC) Cc: 13831@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 13 15:45:31 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFmvp-000319-Lw for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Mar 2013 15:45:29 +0100 Original-Received: from localhost ([::1]:55019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFmvT-0000mY-8X for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Mar 2013 10:45:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFmvO-0000gg-GL for bug-gnu-emacs@gnu.org; Wed, 13 Mar 2013 10:45:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFmvI-0005nx-At for bug-gnu-emacs@gnu.org; Wed, 13 Mar 2013 10:45:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFmvI-0005nm-51 for bug-gnu-emacs@gnu.org; Wed, 13 Mar 2013 10:44:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UFmwL-0000Rk-JV for bug-gnu-emacs@gnu.org; Wed, 13 Mar 2013 10:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Mar 2013 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13831-submit@debbugs.gnu.org id=B13831.13631859131659 (code B ref 13831); Wed, 13 Mar 2013 14:46:01 +0000 Original-Received: (at 13831) by debbugs.gnu.org; 13 Mar 2013 14:45:13 +0000 Original-Received: from localhost ([127.0.0.1]:51384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFmvY-0000Qh-Ir for submit@debbugs.gnu.org; Wed, 13 Mar 2013 10:45:12 -0400 Original-Received: from mail-ea0-f170.google.com ([209.85.215.170]:55437) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFmvV-0000QU-Gl for 13831@debbugs.gnu.org; Wed, 13 Mar 2013 10:45:10 -0400 Original-Received: by mail-ea0-f170.google.com with SMTP id a15so483572eae.29 for <13831@debbugs.gnu.org>; Wed, 13 Mar 2013 07:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=x6KaRSVJ4yEOV1nVJAmVN5RWJKJmNMm6KaJSx488EZ4=; b=P3Z7F5wwRfZrCs4ftwRBUGLz44g3gr7RF4a43mJJZ0eLP0LN+kTTCOKlV9oNo0rQka KhBKkoBy09bysqNmrDCdCccAn4mwFc5eH1Dv9a0thdL2j0+a0xYD/AxyVQBy+B1wHFrK pi+ytZEIgzI+AH6qknKZKjpomzkUHIZZopKFQ/7LrQDk2P/Nw+Wt8QDSSDwBqx8tZSU2 g+88QDxz11K2PxHY3SI+K0CFEXUcKWIixmVgtmie3INjjn5Kti7/Tf2sV/XGoMWUv6EI aFWRihyPz95sEg2AiFYUgJ0xjAJQsoyMdr89rXiBhsnsh1Pi2KPNEvzVeDnE0bz5m9YE Ni0Q== X-Received: by 10.14.223.199 with SMTP id v47mr59702151eep.18.1363185837531; Wed, 13 Mar 2013 07:43:57 -0700 (PDT) Original-Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id 44sm36392496eek.5.2013.03.13.07.43.55 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 13 Mar 2013 07:43:56 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 11 Mar 2013 14:31:22 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72417 Archived-At: Hi Stefan, Stefan Monnier writes: > Installed, thank you, Ok thanks. Also here something wrong also: --8<---------------cut here---------------start------------->8--- ;; Simplified versions of some at-point functions from ffap.el. ;; It's not worth loading all of ffap just for these. (defun net-utils-machine-at-point () --8<---------------cut here---------------end--------------->8--- This function return not only machine but anything at point, which is annoying. Thus we find some lines later: --8<---------------cut here---------------start------------->8--- (read-from-minibuffer "Lookup host: " (or (ffap-string-at-point 'machine) "")))) --8<---------------cut here---------------end--------------->8--- And ffap is not required. I think actually it is not a problem loading ffap when needed: --8<---------------cut here---------------start------------->8--- (defun net-utils-machine-at-point () (require 'ffap) (ffap-machine-at-point)) (defun net-utils-url-at-point () (require 'ffap) (ffap-url-at-point)) --8<---------------cut here---------------end--------------->8--- This reduce code and do the right thing. I can send a patch if ok. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997