From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Any exceptions for the 15-line rule? Date: Sat, 27 Apr 2013 07:20:42 +0400 Message-ID: <87d2tgu0ad.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367032850 20100 80.91.229.3 (27 Apr 2013 03:20:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Apr 2013 03:20:50 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 27 05:20:55 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UVvh0-0005fL-BE for ged-emacs-devel@m.gmane.org; Sat, 27 Apr 2013 05:20:54 +0200 Original-Received: from localhost ([::1]:43688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVvgz-0000lX-Of for ged-emacs-devel@m.gmane.org; Fri, 26 Apr 2013 23:20:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVvgu-0000lS-QT for emacs-devel@gnu.org; Fri, 26 Apr 2013 23:20:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVvgt-0001SU-K4 for emacs-devel@gnu.org; Fri, 26 Apr 2013 23:20:48 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:52078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVvgt-0001SP-BZ for emacs-devel@gnu.org; Fri, 26 Apr 2013 23:20:47 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UVvgq-0005Vx-Vs for emacs-devel@gnu.org; Sat, 27 Apr 2013 05:20:44 +0200 Original-Received: from 178.252.98.87 ([178.252.98.87]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Apr 2013 05:20:44 +0200 Original-Received: from dgutov by 178.252.98.87 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Apr 2013 05:20:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 178.252.98.87 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) Cancel-Lock: sha1:odn0RFaRgjNT6A/KwfZwpbyiSjw= X-Antivirus: avast! (VPS 130426-1, 27.04.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159175 Archived-At: I've received a pull request [0] today for company-mode's Clang backend that's essentially a request to borrow some (fairly simple) code from the auto-complete-clang project [1]. The latter is licensed under GPLv3+, but I'm pretty sure the author (brianjcj AT gmail, not sure what's his full name) has not signed the CA. And I'm not wild about the idea of waiting several months to add the feature (that is, if the author even agrees to sign the CA). The change itself is almost entirely dictated by the interface provided by the clang program, so while I can tweak a thing here and there to try to create an independent implementation, it's not like solving a complex problem, which you can approach from different directions. For example, the definition of `company-clang--lang-option' the patch [2] adds is more or less what takes it over the 15 lines limit. I said I'll try to rewrite it, but should I bother? It's basically a set of information about what values the "-x" option takes, and while I can replace the main `cond' with the less efficient `replace-string', the result will still resemble the original very strongly. Speaking of one of the stated reasons behind the CA, this is not the kind of code I'd ever expect FSF to go to court over. --Dmitry [0] https://github.com/company-mode/company-mode/pull/17 [1] https://github.com/brianjcj/auto-complete-clang [2] https://github.com/company-mode/company-mode/pull/17.diff