From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Xue Fuqiao <xfq.free@gmail.com>, 15466@debbugs.gnu.org
Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode
Date: Thu, 26 Sep 2013 20:38:00 +0200 [thread overview]
Message-ID: <87d2nv5szb.fsf@thinkpad.tsdh.org> (raw)
In-Reply-To: <jwv7ge3zcj6.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Thu, 26 Sep 2013 14:05:09 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (define-key map (kbd "RET") 'image-next-line)
>> ;; Zoom in/out.
>> (define-key map "+" 'doc-view-enlarge)
>> + (define-key map "=" 'doc-view-enlarge)
>> + (define-key map (kbd "C-x C-+") 'doc-view-enlarge)
>> + (define-key map (kbd "C-x C-=") 'doc-view-enlarge)
>> (define-key map "-" 'doc-view-shrink)
>> + (define-key map (kbd "C-x C--") 'doc-view-shrink)
>> ;; Fit the image to the window
>> (define-key map "W" 'doc-view-fit-width-to-window)
>> (define-key map "H" 'doc-view-fit-height-to-window)
>
> I think it's OK (unless Tassilo disagrees, obviously),
No, it's fine with me.
> Also, maybe instead of rebinding C-x C-+, we should remap
> text-scale-adjust.
Yeah
(define-key map [remap text-scale-adjust] 'doc-view-enlarge)
(define-key map (kbd "C-x C--") 'doc-view-shrink)
should be equivalent. Well, except that C-x C-0 would also enlarge. It
wouldn't be bad to have a command to reset to the original size. That
shouldn't be hard to do. In the non-ImageMagick case, it's killing the
buffer-local value of doc-view-resolution and reconverting, and in the
ImageMagick case it's just killing the local value of
doc-view-image-width and re-inserting the image with
doc-view-insert-image.
Bye,
Tassilo
next prev parent reply other threads:[~2013-09-26 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:14 bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Xue Fuqiao
2013-09-26 18:05 ` Stefan Monnier
2013-09-26 18:38 ` Tassilo Horn [this message]
2013-09-26 19:08 ` Tassilo Horn
2013-09-27 6:50 ` Tassilo Horn
2013-09-27 13:04 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2nv5szb.fsf@thinkpad.tsdh.org \
--to=tsdh@gnu.org \
--cc=15466@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=xfq.free@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.