From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r114534: Get Ruby's SMIE code to pass the test suite. Date: Mon, 07 Oct 2013 00:40:35 +0300 Message-ID: <87d2nijcx8.fsf@yandex.ru> References: <87eh7z1c8u.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1381095663 15566 80.91.229.3 (6 Oct 2013 21:41:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Oct 2013 21:41:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 06 23:41:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VSw4X-0005Cg-N7 for ged-emacs-devel@m.gmane.org; Sun, 06 Oct 2013 23:41:05 +0200 Original-Received: from localhost ([::1]:56518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSw4X-0005Cj-91 for ged-emacs-devel@m.gmane.org; Sun, 06 Oct 2013 17:41:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSw4J-0005CY-WD for emacs-devel@gnu.org; Sun, 06 Oct 2013 17:40:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSw4D-00055L-MZ for emacs-devel@gnu.org; Sun, 06 Oct 2013 17:40:51 -0400 Original-Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:63156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSw4D-00055F-F6 for emacs-devel@gnu.org; Sun, 06 Oct 2013 17:40:45 -0400 Original-Received: by mail-ee0-f49.google.com with SMTP id d41so2802014eek.22 for ; Sun, 06 Oct 2013 14:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=r/wCV4sO4WqSGTmBQkJeuq0yfzEw3a2Me3EQFJiaov4=; b=rBiol8iLb6udikUTG39qM8ZaNWK/wVyo2P3wtn8NlP1/eMUCKS1MXLNUUDiuVnnG29 7w1TDvl9qWA2oBT/kbMselDRyUCoiBMPH3JmeK8pYf+S7/xIgUbxLs1ret/+epRyzaOA bdWUYLgj0ANRQtQLn2427xvdYw83PcawTPvLckx2TK6xLUaPySznoYqnxrl5lpjLcEHk soytwdkYEouyxoeGslM6jAyH3Z3lp/e789J9ZeoDSVPz6ckvkB0Se7dHcN+0MzUer81s fRSyvHhlL2L4FuELcyBYWKrM7bWshBg64kjsPFIGrtaz4mAjZbDSBi5jYr9nGpXKQp2j Blzw== X-Received: by 10.15.36.9 with SMTP id h9mr43840213eev.30.1381095644553; Sun, 06 Oct 2013 14:40:44 -0700 (PDT) Original-Received: from axl (93-113-74.netrun.cytanet.com.cy. [93.109.113.74]) by mx.google.com with ESMTPSA id k7sm55410269eeg.13.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 06 Oct 2013 14:40:43 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 06 Oct 2013 12:45:20 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163931 Archived-At: Stefan Monnier writes: > It's only one test. If you mean the example for Bug#15369, you're forgetting the ruby-deep-indent-* examples, they can't all pass using the old engine, with the same value of ruby-deep-indent-paren. > old engine (not "default" any more). Indeed. >> automation. Do you intend to eventually remove it from >> automated/ruby-mode-tests.el? I'd be firmly against that. > > Knowing that it's a sensitive issue, I just stay away from > ruby-mode-tests.el. Ok, thank you. >> This one doesn't work for me. With SMIE, it indents like this: > >> MSG = 'Separate every 3 digits in the integer portion of a number' \ >> 'with underscores(_).' > > I installed a fix to smie.el at the same time. The indentation you show > is the one you get with the old smie.el. Right, sorry. My smie.elc was stale. Could you take a look at the examples I added in 114537 and 114538? They're fairly characterisitc of real-life code (except the optional "do", I guess).