From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r114534: Get Ruby's SMIE code to pass the test suite.
Date: Mon, 07 Oct 2013 00:40:35 +0300 [thread overview]
Message-ID: <87d2nijcx8.fsf@yandex.ru> (raw)
In-Reply-To: <jwv7gdqmjwb.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 06 Oct 2013 12:45:20 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> It's only one test.
If you mean the example for Bug#15369, you're forgetting the
ruby-deep-indent-* examples, they can't all pass using the old engine,
with the same value of ruby-deep-indent-paren.
> old engine (not "default" any more).
Indeed.
>> automation. Do you intend to eventually remove it from
>> automated/ruby-mode-tests.el? I'd be firmly against that.
>
> Knowing that it's a sensitive issue, I just stay away from
> ruby-mode-tests.el.
Ok, thank you.
>> This one doesn't work for me. With SMIE, it indents like this:
>
>> MSG = 'Separate every 3 digits in the integer portion of a number' \
>> 'with underscores(_).'
>
> I installed a fix to smie.el at the same time. The indentation you show
> is the one you get with the old smie.el.
Right, sorry. My smie.elc was stale.
Could you take a look at the examples I added in 114537 and 114538?
They're fairly characterisitc of real-life code (except the optional
"do", I guess).
next prev parent reply other threads:[~2013-10-06 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VSWj3-0005Os-CP@vcs.savannah.gnu.org>
2013-10-06 0:20 ` trunk r114534: Get Ruby's SMIE code to pass the test suite Dmitry Gutov
2013-10-06 16:45 ` Stefan Monnier
2013-10-06 21:40 ` Dmitry Gutov [this message]
2013-10-07 4:05 ` Stefan Monnier
2013-10-21 6:14 ` Dmitry Gutov
2013-10-21 12:46 ` Stefan Monnier
2013-10-21 14:16 ` Dmitry Gutov
2013-10-21 16:46 ` Stefan Monnier
2013-10-21 22:30 ` Dmitry Gutov
2013-10-22 15:46 ` Stefan Monnier
2013-10-22 15:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2nijcx8.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.