From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] ispell.el: Ensure trailing wildcard when looking up words with grep Date: Sat, 09 Nov 2013 03:16:58 +0200 Message-ID: <87d2mabchh.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383959842 21883 80.91.229.3 (9 Nov 2013 01:17:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Nov 2013 01:17:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ingo Lohmar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 09 02:17:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VexB0-0002rE-Qs for ged-emacs-devel@m.gmane.org; Sat, 09 Nov 2013 02:17:26 +0100 Original-Received: from localhost ([::1]:52681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VexB0-0000DZ-2R for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2013 20:17:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VexAq-0000CX-3M for emacs-devel@gnu.org; Fri, 08 Nov 2013 20:17:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VexAh-0000or-NI for emacs-devel@gnu.org; Fri, 08 Nov 2013 20:17:16 -0500 Original-Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:38517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VexAh-0000od-GJ for emacs-devel@gnu.org; Fri, 08 Nov 2013 20:17:07 -0500 Original-Received: by mail-ee0-f45.google.com with SMTP id l10so717320eei.32 for ; Fri, 08 Nov 2013 17:17:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=5THnOBqQBPbStszEMOAJ7f+kH3F2V5E/a+zeuZNbE94=; b=sr7yWVP38NvzwPbTlETqUaHAbHCBD5j9iy5jRfYgHRZiT9UK5gg0Cjkg4xpmwAFC0h c9i6qHXPXDC8jrjZ1Kfbr3+BX3+eY+NCrB6ONOFaQwRnmzas6q8uBGYqk0CPSfukmIvf ZPNRamPT695Xmy615U+Y398S61VUqTSzRumBmdQtvFGak8TjP6bASCfBe9cnU/U0ZNJC bMeAL3F7gnlhRzzbP0U9OTzTSjDfBw7hYmyDaO5HlRc9/sXYwqeXNhpZtJJA0tfe9I3s uKf6PV1qUvmjti8BwvJsv2dDLSKMp+WSpx8YEW8bz9X/3TkQJD2oUJ32OKcochYg+LLO cckg== X-Received: by 10.14.219.198 with SMTP id m46mr19782021eep.41.1383959826409; Fri, 08 Nov 2013 17:17:06 -0800 (PST) Original-Received: from axl (93-25-160.netrun.cytanet.com.cy. [93.109.25.160]) by mx.google.com with ESMTPSA id k7sm21302484eeg.13.2013.11.08.17.17.04 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 08 Nov 2013 17:17:05 -0800 (PST) In-Reply-To: (Ingo Lohmar's message of "Thu, 7 Nov 2013 09:40:00 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165084 Archived-At: Hi Ingo, Ingo Lohmar writes: > Using company-mode for plain-text completion on a windows system (no > look, only grep) exhibits a bug where the grep regexp lacks a trailing > wildcard. Attached short patch fixes this and has been working for me > for some time now. Unfortunately, you patch didn't work for me. At the time you're checking for trailing ".*", `word' already ends with "$" (so the check always fails), and when you append ".*", that also goes after "$", which doesn't seem valid. I've installed a different patch in revision 115045, please see if it works for you.