From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vitalie Spinu Newsgroups: gmane.emacs.bugs Subject: bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer Date: Sat, 30 Nov 2013 00:38:25 -0800 Message-ID: <87d2limghq.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1385800821 6100 80.91.229.3 (30 Nov 2013 08:40:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Nov 2013 08:40:21 +0000 (UTC) To: 16011@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 30 09:40:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vmg6C-0003vo-26 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2013 09:40:24 +0100 Original-Received: from localhost ([::1]:51283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmg6B-0003M6-MY for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2013 03:40:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmg60-0003Lz-UU for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:40:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmg5s-0003yB-GP for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:40:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmg5s-0003xp-Cs for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:40:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vmg5q-00040Z-Mo for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2013 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16011 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138580074515332 (code B ref -1); Sat, 30 Nov 2013 08:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Nov 2013 08:39:05 +0000 Original-Received: from localhost ([127.0.0.1]:51096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vmg4u-0003zE-JX for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:39:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46602) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vmg4q-0003yh-Fd for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:39:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmg4c-0003gr-Pu for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:38:55 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmg4c-0003gb-NO for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:38:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmg4U-0002Vm-96 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:38:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmg4L-0003Vz-Pw for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:38:38 -0500 Original-Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:62796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmg4L-0003UH-Hb for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:38:29 -0500 Original-Received: by mail-pd0-f177.google.com with SMTP id q10so14957691pdj.22 for ; Sat, 30 Nov 2013 00:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=BbhGTJX4lpMee2bibPAi8HAJEN1nf1XGmePq/fRhdHU=; b=eU3NgPIrgwiw+EYddbf7++6O8CXCvMkwOPlQG5VGoRUiurCe9UwKsnto8aTCaFc4U2 SHzv+seyCTFVhGuHyE+Ro61JHOaYv1X585fCgkU3mZ39cm8z7ga1v5O4Q5qY/K0fC5Ds bsrhA6T/qQJjf9sEIkLEQ+hwR+LRq/PdmSB68bC7cxOCm1x8Q4cpK0vMLmM6ZnVAqHSZ YoTKj3oKnLM4O4GsGOANC4SeKBggC7CC++6zPQyATGszemZ8VvjGycLGRaXYdFyZ0oeY cbNm0Uyuw5ZiSk/XwiJ1Az93LlZqW1IaKQofjqZP7mt2qH6scUinWBqtBHZHIInCv7MH VNkg== X-Received: by 10.68.59.202 with SMTP id b10mr20634109pbr.78.1385800708305; Sat, 30 Nov 2013 00:38:28 -0800 (PST) Original-Received: from localhost (cs178-201.anderson.ucla.edu. [164.67.178.201]) by mx.google.com with ESMTPSA id m2sm13460972pbn.19.2013.11.30.00.38.26 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 30 Nov 2013 00:38:27 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81131 Archived-At: --=-=-= Content-Type: text/plain Hi, On error, message-send-mail-with-sendmail pops to the error message buffer with an obvious intention for the user to see it. But then kills the buffer. Consequently the user sees only a completely useless, emacs generated message like: error: "Sending...failed with exit value 78" Vitalie --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-message-send-mail-with-sendmail-don-t-kill-error-buf.patch >From 757150148ebd6ac841133010b31c807191bf448b Mon Sep 17 00:00:00 2001 From: Vitalie Spinu Date: Sat, 30 Nov 2013 00:26:42 -0800 Subject: [PATCH] message-send-mail-with-sendmail: don't kill error buffer on error --- lisp/gnus/message.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index b7d0ada..f96cd7a 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -4739,7 +4739,9 @@ that instead." (list resend-to-addresses) '("-t")))))) (unless (or (null cpr) (and (numberp cpr) (zerop cpr))) - (if errbuf (pop-to-buffer errbuf)) + (when errbuf + (pop-to-buffer errbuf) + (setq errbuf nil)) (error "Sending...failed with exit value %d" cpr))) (when message-interactive (with-current-buffer errbuf -- 1.8.1.2 --=-=-=--