From: Vitalie Spinu <spinuvit@gmail.com>
To: 16011@debbugs.gnu.org
Subject: bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer
Date: Sat, 30 Nov 2013 00:38:25 -0800 [thread overview]
Message-ID: <87d2limghq.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
Hi,
On error, message-send-mail-with-sendmail pops to the error message
buffer with an obvious intention for the user to see it. But then kills
the buffer.
Consequently the user sees only a completely useless, emacs generated
message like:
error: "Sending...failed with exit value 78"
Vitalie
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-message-send-mail-with-sendmail-don-t-kill-error-buf.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]
From 757150148ebd6ac841133010b31c807191bf448b Mon Sep 17 00:00:00 2001
From: Vitalie Spinu <spinuvit@gmail.com>
Date: Sat, 30 Nov 2013 00:26:42 -0800
Subject: [PATCH] message-send-mail-with-sendmail: don't kill error buffer on
error
---
lisp/gnus/message.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index b7d0ada..f96cd7a 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -4739,7 +4739,9 @@ that instead."
(list resend-to-addresses)
'("-t"))))))
(unless (or (null cpr) (and (numberp cpr) (zerop cpr)))
- (if errbuf (pop-to-buffer errbuf))
+ (when errbuf
+ (pop-to-buffer errbuf)
+ (setq errbuf nil))
(error "Sending...failed with exit value %d" cpr)))
(when message-interactive
(with-current-buffer errbuf
--
1.8.1.2
next reply other threads:[~2013-11-30 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 8:38 Vitalie Spinu [this message]
2013-12-03 1:06 ` bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2limghq.fsf@gmail.com \
--to=spinuvit@gmail.com \
--cc=16011@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.