From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Newsgroups: gmane.emacs.bugs Subject: bug#16346: 24.3; electric-pair-mode close-paren issue Date: Sun, 05 Jan 2014 19:25:32 +0000 Message-ID: <87d2k6temr.fsf@gmail.com> References: <878uuuy7g1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1388950096 7733 80.91.229.3 (5 Jan 2014 19:28:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jan 2014 19:28:16 +0000 (UTC) Cc: 16346@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 05 20:28:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VztMz-0002HQ-9B for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 20:28:21 +0100 Original-Received: from localhost ([::1]:59152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VztMy-0008Vh-Mj for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 14:28:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VztMo-0008VT-1y for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 14:28:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VztMg-0001z7-PG for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 14:28:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VztMg-0001z3-M3 for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 14:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VztMg-0006IU-1g for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 14:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2014 19:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16346 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16346-submit@debbugs.gnu.org id=B16346.138895006224166 (code B ref 16346); Sun, 05 Jan 2014 19:28:01 +0000 Original-Received: (at 16346) by debbugs.gnu.org; 5 Jan 2014 19:27:42 +0000 Original-Received: from localhost ([127.0.0.1]:36723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VztMK-0006He-C2 for submit@debbugs.gnu.org; Sun, 05 Jan 2014 14:27:40 -0500 Original-Received: from mail-wg0-f46.google.com ([74.125.82.46]:35763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VztMH-0006HW-JR for 16346@debbugs.gnu.org; Sun, 05 Jan 2014 14:27:38 -0500 Original-Received: by mail-wg0-f46.google.com with SMTP id m15so14875660wgh.13 for <16346@debbugs.gnu.org>; Sun, 05 Jan 2014 11:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=7/n7Rhi1gSmBQQKGiiudkxpeAK5iu8s1ZN5Tted3AFY=; b=Dn+BQSbEbi5XzhJm4WzpT84U8IcaEYbDXDQpiRwrSdIBnGEZBHj4sjFZLUJucvkWmT 4yHQ5ly3yWpA8eMnxR58chTUjVplnmd6ETLQjLY6qOTsY7ivYZiSlgXv2zee089zrI+j xmdmHVSYb6LBRqATOdA7gQ5YdXii3Pu6j8tmp2j1H2hFzk/04E0HMgA9LRPsMiOf/IEy YOO1QcOGabxmEJLuxYuusKIfJwVK7pqKb7eB0VUmXTDmL20lef66SYWCrqRjyaS6oORW +ePBsShveENFN5SQuUAwapqpMBj2lcVOifarpHsBjgnRxa2AeQ10tCNfbx9gWMyTXOAJ TWnw== X-Received: by 10.194.2.11 with SMTP id 11mr212429wjq.82.1388950056686; Sun, 05 Jan 2014 11:27:36 -0800 (PST) Original-Received: from kitaj.yourcompany.com (66.207.108.93.rev.vodafone.pt. [93.108.207.66]) by mx.google.com with ESMTPSA id hv3sm14058292wib.5.2014.01.05.11.27.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 05 Jan 2014 11:27:35 -0800 (PST) In-Reply-To: (Leo Liu's message of "Sun, 05 Jan 2014 23:30:47 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83022 Archived-At: Leo Liu writes: >> Are you sure this is only with the new features? > Yes. Funny, `electric-pair--insert' was also being called with the previous `electric-pair-mode' to insert matchers and it didn't change. The previous version did sometimes match ( didn't it? :) > But this may break the other half of stuff using > post-self-insert-hook? Yes, more or less I think that was the gist of the FIXME notes that Stefan had added there. OTOH, it's useful, for example, when newlines are inserted. electric-indent-mode has a chance to kick in there. Let's look at this this way, if the user pressed `(', `)' and `C-b' in sucession, what would that "half of stuff" do? This is what electric-pair more or less emulates. On the other hand, we can decide to insert matchers using simple `insert'. Stefan any thoughts? > Add (eldoc-post-insert-mode nil) fixes this bug. Nice, looks good, maybe you could commit this and maybe add a test or two. I can only look at this at the end of the week, sorry.