all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Witness computation - minor breakage in the build system
@ 2014-01-12  4:37 Eric S. Raymond
  2014-01-12  4:50 ` Paul Eggert
  2014-01-13  3:16 ` Glenn Morris
  0 siblings, 2 replies; 24+ messages in thread
From: Eric S. Raymond @ 2014-01-12  4:37 UTC (permalink / raw)
  To: emacs-devel

Is any particular person responsible for the build system?

While working on one of my to-do items I found an apparent bug
in Makefile.in.  The src production tries to compute the location 
of a "witness" file with modtime taken as the time of most recent
repository change.

The computation is wrong, however, and fails - leaving VCSWITNESS 
empty.  This has escaped notice because the effect is subtle: 
re-dumping may not always be forced when it should be after a
repository update.  To see that this true, add code just before
the make invocation on line 384 to dump $vcswitness.  Don't forget
to double the $.

I stumbled over this because part of my transition plan is to get
the code to a state where it can do a full build (with proper revision
ID amd conditional dumping) regardless of whether the underlying 
repo is Bazaar or Git.

I could patch-fix this.  But I think the fixed Makefile code would
remain unpleasantly fragile, and the witness-path computation is
best moved to the configure stage.

Comments? Objections? Is anyone else willing to take respomsibility
for this?
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is
a well-armed lamb contesting the vote!
	-- Benjamin Franklin



^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2014-01-13 14:06 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12  4:37 Witness computation - minor breakage in the build system Eric S. Raymond
2014-01-12  4:50 ` Paul Eggert
2014-01-12  5:08   ` Eric S. Raymond
2014-01-12 14:52     ` Stefan Monnier
2014-01-12 14:57       ` Eric S. Raymond
2014-01-12 19:36         ` Stefan Monnier
2014-01-12 19:45           ` David Kastrup
2014-01-12 19:53             ` Andreas Schwab
2014-01-12 20:07               ` David Kastrup
2014-01-12 15:57     ` Eli Zaretskii
2014-01-12 14:51   ` Stefan Monnier
2014-01-12 15:56   ` Eli Zaretskii
2014-01-12 19:22     ` Paul Eggert
2014-01-12 19:43       ` Eric S. Raymond
2014-01-12 22:29         ` Stefan Monnier
2014-01-12 22:51           ` Paul Eggert
2014-01-13  3:14             ` Stefan Monnier
2014-01-13  3:44               ` Paul Eggert
2014-01-13  4:16                 ` Stefan Monnier
2014-01-13  6:27                   ` Paul Eggert
2014-01-13 14:06                     ` Stefan Monnier
2014-01-12 21:01       ` Eli Zaretskii
2014-01-12 19:15   ` Glenn Morris
2014-01-13  3:16 ` Glenn Morris

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.