From: Ian Kelling <ian@iankelling.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix error prone babel table output format detection
Date: Thu, 01 May 2014 02:13:05 -0700 [thread overview]
Message-ID: <87d2fxlv4u.fsf@treetowl.lan> (raw)
In-Reply-To: <87eh0dnbot.fsf@treetowl.lan> (Ian Kelling's message of "Thu, 01 May 2014 01:30:10 -0700")
Ian Kelling <ian@iankelling.org> writes:
> Achim Gratz <Stromeko@nexgo.de> writes:
>
>> Ian Kelling writes:
>>> org-babel table output uses different formatting for a list of lists,
>>> but detects it incorrectly causing an error, as in this example:
>>> #+begin_src emacs-lisp
>>> '((1) 2)
>>> #+end_src
>>
>> So this isn't a proper table, what do you expect to happen?
>
> I expect to be able to emacs -q, make an org mode buffer containing
> that block, do ctrl-c c on it, and not have an error message pop up and
> fail to have any output. What is improper about it? Would it be better
> if org did not try to format it as a table?
Actually, I see what you mean by improper.
>
>>
>>> - (and (listp (car result))
>>> - (listp (cdr (car result)))))
>>> + (cl-every 'listp result))
>>
>> This is wrong, because a table can come with any number of 'hline
>> symbols, so ostensibly not every element will be a listp.
>
> Yes, I agree. It will have to test if elements are listp or hline.
>
>
>> Besides, you
>> can't use cl-every unless Org drops backwards compatibility with older
>> Emacsen or mandates cl-lib to be present. Even then, you'd also need to
>> require cl-extra.
>
> I forgot about the multiple parts of cl. I originally wrote it without,
> and can change it.
Below is a patch that addresses the 2 previously mentioned
problems.
-- >8 --
Subject: [PATCH] Fix error prone babel table output format detection
* lisp/ob-core.el: Test that all elements are in a list are lists or
'hline instead of just the first.
org-babel table output uses different formatting for a list of lists,
but detects it incorrectly causing an error, as in this example:
#+begin_src emacs-lisp
'((1) 2)
#+end_src
---
lisp/ob-core.el | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 1348f04..b5b0bc7 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2184,9 +2184,16 @@ code ---- the results are extracted in the syntax of the source
((funcall proper-list-p result)
(goto-char beg)
(insert (concat (orgtbl-to-orgtbl
- (if (or (eq 'hline (car result))
- (and (listp (car result))
- (listp (cdr (car result)))))
+ (if (let ((len (length result))
+ (proper t)
+ (i 0)
+ elem)
+ (while (and proper (< i len ))
+ (setq elem (nth i result))
+ (unless (or (listp elem) (eq elem 'hline))
+ (setq proper nil))
+ (setq i (1+ i)))
+ proper)
result (list result))
'(:fmt (lambda (cell) (format "%s" cell)))) "\n"))
(goto-char beg) (when (org-at-table-p) (org-table-align)))
--
1.7.10.4
next prev parent reply other threads:[~2014-05-01 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 4:56 [PATCH] Fix error prone babel table output format detection Ian Kelling
2014-05-01 7:08 ` Achim Gratz
2014-05-01 8:30 ` Ian Kelling
2014-05-01 9:13 ` Ian Kelling [this message]
2014-05-01 9:32 ` Ian Kelling
2014-05-01 9:55 ` Ian Kelling
2014-05-04 15:51 ` Eric Schulte
2014-05-04 19:42 ` Ian Kelling
2014-05-07 9:15 ` Eric Schulte
2014-05-07 20:57 ` Ian Kelling
2014-05-21 13:05 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2fxlv4u.fsf@treetowl.lan \
--to=ian@iankelling.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.