From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daimrod Newsgroups: gmane.emacs.bugs Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Date: Sat, 14 Jun 2014 01:08:52 +0900 Message-ID: <87d2ecbxm3.fsf@tanger.home> References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> <539AF3E5.2060102@gmx.at> <83oaxxvswz.fsf@gnu.org> <539B0956.3060003@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1402675850 10455 80.91.229.3 (13 Jun 2014 16:10:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Jun 2014 16:10:50 +0000 (UTC) Cc: 17769@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 13 18:10:44 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WvU3Y-00034e-0S for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 18:10:20 +0200 Original-Received: from localhost ([::1]:59967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvU3X-00035L-El for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 12:10:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvU3N-00032e-QV for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 12:10:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvU3H-0007t1-9U for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 12:10:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvU3H-0007sO-6I for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 12:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WvU3G-0006nC-4g for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 12:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.140267575326011 (code B ref 17769); Fri, 13 Jun 2014 16:10:01 +0000 Original-Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 16:09:13 +0000 Original-Received: from localhost ([127.0.0.1]:46853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvU2O-0006lM-TH for submit@debbugs.gnu.org; Fri, 13 Jun 2014 12:09:12 -0400 Original-Received: from mail-pb0-f48.google.com ([209.85.160.48]:45253) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvU2J-0006ki-G1 for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 12:09:07 -0400 Original-Received: by mail-pb0-f48.google.com with SMTP id rq2so200315pbb.35 for <17769@debbugs.gnu.org>; Fri, 13 Jun 2014 09:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=PVdKeIXElQXcTZYQCujgm7SODEv7sQEmQAJ9weY+MZo=; b=XvE/n96NfDSgq1jtQw79XZFoJzAkNeDb6EkNtiG4iA3DOGupVcTFqb0PlzMFOACaLw oggcJq/mumzpzewPg/cwL+eJ/iutcTY9M9dC+AKM3PUBfCu/VnRuXOFqzlzMT1Lkn1/S u4xYsUxFT3gJukGkIkggvqxuRvJyDNbW4Q6itRqcJKPEeWLCD6IjRVfCLJr/QCxyJTBd Avhr9fWU8fLV/+7iw8wnjG0Vg42HGYGNCe+J0mWzUK39R0bK+RQeNQY8vCoideFa29MX iH/w8d+AtMIvjf/ot35sEWvKu3LL+EOJ5/sPYfBhq/J+y41XZJRmXP5BDCkk7mv8uD2T yeoQ== X-Received: by 10.68.190.74 with SMTP id go10mr4735542pbc.16.1402675737463; Fri, 13 Jun 2014 09:08:57 -0700 (PDT) Original-Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id qf10sm4361887pbc.23.2014.06.13.09.08.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 09:08:55 -0700 (PDT) In-Reply-To: <539B0956.3060003@gmx.at> (martin rudalics's message of "Fri, 13 Jun 2014 16:23:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90347 Archived-At: --=-=-= Content-Type: text/plain martin rudalics writes: >>> Strictly spoken this should read "But if it is displayed in the selected >>> window, recenter that window." >> >> No, because in that case it would already have been done by a normal >> call to recenter. > > Unless the selected window displayed another buffer. Then you probably > mean something like > > (dolist (window (get-buffer-window-list buffer)) > (with-selected-window window (recenter))) I see, thanks for inputs. Here is an updated patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-omit-mode-recenter-the-corre.patch >From c9fb7786be4fd929ad81861b3ada47d8d2f385e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Sat, 14 Jun 2014 00:57:06 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-omit-mode): `recenter' the correct windows. --- lisp/net/rcirc.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..a0e72d1 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,9 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (dolist (window (get-buffer-window-list (current-buffer))) + (with-selected-window window + (recenter (when (> (point) rcirc-prompt-start-marker) -1))))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=--