From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Date: Tue, 05 Aug 2014 03:11:05 +0300 Organization: JURTA Message-ID: <87d2cfrcny.fsf@mail.jurta.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1407199470 8623 80.91.229.3 (5 Aug 2014 00:44:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Aug 2014 00:44:30 +0000 (UTC) Cc: 18189@debbugs.gnu.org To: Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 05 02:44:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XESrW-0007og-JI for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Aug 2014 02:44:22 +0200 Original-Received: from localhost ([::1]:55724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XESrW-0004dC-9P for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Aug 2014 20:44:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XESrK-0004c9-UF for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 20:44:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XESrD-0005Il-EY for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 20:44:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XESrD-0005Ih-B4 for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 20:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XESrC-00049C-Mb for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 20:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Aug 2014 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18189-submit@debbugs.gnu.org id=B18189.140719938315862 (code B ref 18189); Tue, 05 Aug 2014 00:44:02 +0000 Original-Received: (at 18189) by debbugs.gnu.org; 5 Aug 2014 00:43:03 +0000 Original-Received: from localhost ([127.0.0.1]:58024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XESqE-00047k-MB for submit@debbugs.gnu.org; Mon, 04 Aug 2014 20:43:03 -0400 Original-Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:56421 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XESqA-00047H-FR for 18189@debbugs.gnu.org; Mon, 04 Aug 2014 20:42:59 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 09A6D3130E5294; Mon, 4 Aug 2014 17:42:56 -0700 (PDT) In-Reply-To: (Paul Pogonyshev's message of "Mon, 4 Aug 2014 15:18:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92114 Archived-At: > To reproduce: > > - customize the variable and toggle its value; > - observe that annotation buffers still look the same, even if you generate > them anew; > - new variable value is only honored if you restart Emacs. > > Ideally the value should be apply on-the-fly. But at least it should be > applied if I hit 'C-x v g' after customizing the variable. I believe this should be implemented by this patch: === modified file 'lisp/vc/vc-annotate.el' --- lisp/vc/vc-annotate.el 2014-07-08 08:49:18 +0000 +++ lisp/vc/vc-annotate.el 2014-08-05 00:07:51 +0000 @@ -139,6 +139,12 @@ (defcustom vc-annotate-color-map :type 'alist :group 'vc) +(put 'vc-annotate-background-mode 'custom-set + (lambda (symbol value) + (set-default symbol value) + (ignore-errors + (custom-reevaluate-setting 'vc-annotate-color-map)))) + (defcustom vc-annotate-very-old-color (if vc-annotate-background-mode "#CCCCFF" "#3F3FFF") "Color for lines older than the current color range in \\[vc-annotate]." :type 'string